-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JWT auth: cache verifiers #5575
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jumaffre
added
auto-backport
Automatically backport this PR to LTS branch
4.x-todo
PRs which should be backported to 4.x
labels
Aug 21, 2023
achamayou
approved these changes
Aug 21, 2023
It would be good to have the cache size be configurable through governance, in the same way as the other JWT settings, some users may want to cache more than 10 verifiers etc. |
cache_jwt_verifier@74782 aka 20230821.19 vs main ewma over 20 builds from 74378 to 74756 Click to see tablemain
cache_jwt_verifier
|
ghost
mentioned this pull request
Aug 21, 2023
ghost
pushed a commit
that referenced
this pull request
Aug 21, 2023
(cherry picked from commit 054356b)
jumaffre
pushed a commit
that referenced
this pull request
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4.x-todo
PRs which should be backported to 4.x
auto-backport
Automatically backport this PR to LTS branch
backported
This PR was successfully backported to LTS branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5557
To avoid rebuilding a new
crypto::Verifier
for each incoming JWT request (which is particularly expensive with OpenSSL 3.x - see #5557), we now cache a relatively small number of verifiers in the JWT auth layer. This results in a performance increase for all JWT-related tests, which will be even greater with OpenSSL 3.x.