Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/4.x] Cherry pick: Replace Secret Sharing implementation (#5655) #5675

Merged
merged 2 commits into from
Sep 22, 2023
Merged

[release/4.x] Cherry pick: Replace Secret Sharing implementation (#5655) #5675

merged 2 commits into from
Sep 22, 2023

Conversation

achamayou
Copy link
Member

Backports the following commits to release/4.x:

@achamayou
Replace Secret Sharing implementation (microsoft#5655)
693b7ce 
(cherry picked from commit d224a32)

# Conflicts:
#	.daily_canary
#	CHANGELOG.md
#	src/node/share_manager.h
@achamayou achamayou requested a review from a team September 21, 2023 15:51
@achamayou achamayou added the 4.x-backport Highlights PRs targeting the 4.x branch label Sep 21, 2023
@achamayou achamayou enabled auto-merge (squash) September 21, 2023 15:51
@ghost
Copy link

ghost commented Sep 21, 2023 •
edited by ghost
Loading

backport/release/4.x/pr-5655@76294 aka 20230922.5 vs release/4.x ewma over 19 builds from 74885 to 76285

Click to see table

release/4.x

build_id build_number Commit latency factor tpcc_sgx_cft^ tpcc_sgx_cft_mem tpcc_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem ls_virtual_cft^ pi_ls_sgx_cft^ pi_ls_sgx_cft_mem pi_ls_virtual_cft^ ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_jwt_virtual_cft^ pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem pi_ls_jwt_virtual_cft^ ls_js_virtual_cft^ ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_virtual_cft^ ls_js_jwt_virtual_cft^ ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem hist_sgx_cft^ ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
74885 20230823.4 0.787354 7316.88 8.59996e+07 17174.1 19870.8 1.88908e+07 45558.5 20030.1 1.25993e+07 46893.1 9923.09 1.88908e+07 17406.4 9991.3 6.30784e+06 18997.7 4358.03 1710.54 1.05021e+07 3705.83 3669.26 1490.79 1.05021e+07 48043.1 1563.88 1.05021e+07 831686 1.18028e+06 8.15264e+06 3.08592e+07
74940 20230824.3 0.78863 7261.66 8.39025e+07 17143.9 19750.8 1.88908e+07 45734.9 16863.1 1.05021e+07 46799.4 9026.95 1.88908e+07 17247.6 10321.5 6.30784e+06 18623 4346.35 1707.63 1.05021e+07 3764.21 3598.76 1493.33 1.05021e+07 46610.2 1567.02 1.05021e+07 821315 1.18158e+06 8.15218e+06 3.05822e+07
74973 20230825.2 0.791756 7328.94 8.59996e+07 17442.9 19883.1 1.88908e+07 45892.8 20130 1.25993e+07 47452.1 9920.56 1.88908e+07 17309.8 10330.6 6.30784e+06 19442.4 4274.09 1711.77 1.05021e+07 3711.69 3626.43 1492.13 1.05021e+07 50756.4 1564.25 1.05021e+07 836271 1.18102e+06 8.15205e+06 3.08969e+07
75003 20230828.3 0.787123 7317.51 8.59996e+07 17670.1 19800.3 1.88908e+07 43906.5 20220.9 1.25993e+07 47174 10004.8 1.88908e+07 17399.9 9973.6 6.30784e+06 19062.5 4345.17 1707.4 1.05021e+07 3749.43 3625.57 1505.32 1.05021e+07 41973.1 1556.44 1.05021e+07 827983 1.17738e+06 8.14972e+06 3.01807e+07
75017 20230829.1 0.771679 7300.34 8.39025e+07 17308.5 19813.5 1.88908e+07 45692 20124.5 1.25993e+07 47755.7 9932.42 1.88908e+07 17200.9 10006.3 6.30784e+06 19325.1 4325.97 1718.05 1.05021e+07 3693.58 3791.01 1495.86 1.05021e+07 48701.1 1544.6 1.05021e+07 831261 1.18008e+06 8.13609e+06 3.08885e+07
75076 20230830.3 0.785307 7283.3 8.39025e+07 17282.5 19879.2 1.88908e+07 45686.8 20200.5 1.25993e+07 47531.7 9943.71 1.88908e+07 17700.3 9995.4 6.30784e+06 19257.8 4348.93 1708.16 1.05021e+07 3713.29 3666.91 1505.93 1.05021e+07 46216.7 1560.67 1.05021e+07 826647 1.17615e+06 8.1552e+06 3.11365e+07
75141 20230831.3 0.781168 7369.4 8.59996e+07 17106.2 19885.7 1.88908e+07 45589.1 20121.9 1.25993e+07 47632.4 9930.84 1.88908e+07 17317.4 10009.2 6.30784e+06 19099.2 4343.94 1714.27 1.05021e+07 3715.1 3780.54 1496.41 1.05021e+07 45870.5 1560.29 1.05021e+07 831035 1.18071e+06 8.15481e+06 3.08104e+07
75183 20230901.3 0.794042 7346.61 8.59996e+07 17437.3 19934.6 1.88908e+07 45651.6 20188.6 1.25993e+07 47636.1 9943.91 1.88908e+07 17322.4 9998.3 6.30784e+06 19019.7 4327.54 1711.07 1.05021e+07 3594.23 3627.3 1501.16 1.05021e+07 43646 1563.8 1.05021e+07 831108 1.18468e+06 8.15361e+06 3.2284e+07
75256 20230904.3 0.807766 7373.31 8.59996e+07 17071.6 19853.3 1.88908e+07 45793.3 20128.3 1.25993e+07 47404.1 9931.13 1.88908e+07 17444 9973.8 6.30784e+06 19279.7 4404.47 1709.74 1.05021e+07 3729.76 3646.84 1488.27 1.05021e+07 50296.9 1564.92 1.05021e+07 822591 1.17744e+06 8.14923e+06 3.07097e+07
75301 20230905.2 0.756588 7352.76 8.59996e+07 17108.9 19874.9 1.88908e+07 45924.9 20086.9 1.25993e+07 47575.8 9937.23 1.88908e+07 17207.3 9999 6.30784e+06 19342.8 4384.42 1710.02 1.05021e+07 3734.13 3813.72 1492.67 1.05021e+07 46111.6 1562.74 1.05021e+07 829476 1.17788e+06 8.1539e+06 3.05339e+07
75434 20230906.3 0.814451 7317.57 8.59996e+07 17388.8 19846.3 1.88908e+07 45567.3 20089.9 1.25993e+07 46757.2 9918.2 1.88908e+07 17538 10019.6 6.30784e+06 19090.2 4366.19 1707.05 1.05021e+07 3693.47 3654.26 1505.03 1.05021e+07 44194.8 1555.82 1.05021e+07 832702 1.17824e+06 8.1527e+06 3.06688e+07
75523 20230907.4 0.809625 7305.32 8.59996e+07 17085.1 19981.1 1.88908e+07 45751.9 20356.7 1.25993e+07 46749.3 9940.27 1.88908e+07 17197.5 10027.6 6.30784e+06 19443.8 4330.79 1711.21 1.05021e+07 3660.43 3685.06 1505.29 1.05021e+07 50318 1556.28 1.05021e+07 829169 1.1722e+06 8.17385e+06 3.09048e+07
75583 20230908.4 0.799341 7325.75 8.39025e+07 17095 19998.3 1.88908e+07 43717.1 20305.3 1.25993e+07 46017.2 9950.01 1.88908e+07 17739.7 10009.2 6.30784e+06 19324 4234.92 1712.49 1.05021e+07 3708.28 3624.39 1492.19 1.05021e+07 48273.6 1562.08 1.05021e+07 832160 1.18457e+06 8.15296e+06 3.05694e+07
75665 20230911.3 0.770816 7288.09 8.59996e+07 17376.4 20041.2 1.88908e+07 45885.5 20354.1 1.05021e+07 46324.2 9908.42 1.88908e+07 17551.7 9988.9 6.30784e+06 18779 4457.96 1712.89 1.05021e+07 3739.96 3648.03 1507.17 1.05021e+07 43436.1 1560.02 1.05021e+07 834564 1.18809e+06 8.17186e+06 3.06931e+07
75920 20230918.2 0.768212 5579.84 8.59996e+07 17415.6 14048.7 1.67936e+07 45796 14271.7 1.05021e+07 47074.5 6852 1.88908e+07 17426.5 7202.3 6.30784e+06 18950.5 4433.53 1462.07 1.05021e+07 3715.41 3628.69 1283.26 1.05021e+07 47215.3 1291.67 1.05021e+07 833402 1.18448e+06 8.15176e+06 3.1067e+07
75974 20230919.4 0.764615 5607.33 8.59996e+07 17068.4 14144.9 1.88908e+07 45515.7 14282.2 1.05021e+07 47206.4 7307.34 1.67936e+07 17035.4 7254.6 6.30784e+06 17228.9 4403.8 1464.14 1.05021e+07 3649.78 3737.33 1290.05 1.05021e+07 47582.6 1300.19 1.05021e+07 832991 1.17769e+06 8.15416e+06 3.07134e+07
76099 20230920.3 0.769422 5659.06 8.59996e+07 17448.2 14114.6 1.88908e+07 45650 14259.7 1.05021e+07 47597.3 6818.42 1.88908e+07 16959.6 7040.6 6.30784e+06 18965.6 4438.6 1462.46 1.05021e+07 3745.31 3796.36 1281.88 1.05021e+07 45383.9 1303.32 1.05021e+07 834668 1.1819e+06 8.15507e+06 3.07535e+07
76166 20230921.4 0.813695 5615.09 8.59996e+07 17169.6 14082.6 1.88908e+07 45733.3 14266.1 1.05021e+07 47828.6 6868.35 1.67936e+07 17192.7 7201.7 6.30784e+06 18659.5 4396.97 1463.7 1.05021e+07 3744.51 3768.92 1266.47 1.05021e+07 45721.1 1291.86 1.05021e+07 838024 1.18114e+06 8.15316e+06 3.07434e+07
76285 20230922.2 0.799862 5608.04 8.59996e+07 17350 14059.7 1.67936e+07 45581.8 14232 1.05021e+07 44511.9 6855.98 1.67936e+07 17549.7 7188.2 6.30784e+06 19018.3 4173.08 1459.98 1.05021e+07 3702.99 3752.96 1280.53 1.05021e+07 45567.2 1303.05 1.05021e+07 828183 1.17868e+06 8.15433e+06 3.27753e+07

backport/release/4.x/pr-5655

build_id build_number Commit latency factor tpcc_virtual_cft^ ls_virtual_cft^ pi_ls_virtual_cft^ ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_js_virtual_cft^ ls_full_js_virtual_cft^ ls_js_jwt_virtual_cft^ tpcc_sgx_cft^ tpcc_sgx_cft_mem hist_sgx_cft^ ls_sgx_cft^ ls_sgx_cft_mem pi_ls_sgx_cft^ pi_ls_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
76262 20230921.37 0.778685 17356.7 45853.2 48623.7 17274.7 19230.8 4429.35 3728.92 3764.58 5661.98 8.59996e+07 46333.1 14087.4 1.88908e+07 14216.7 1.05021e+07 6865.51 1.67936e+07 7203.7 6.30784e+06 1466.23 1.05021e+07 1287.86 1.05021e+07 1302.27 1.05021e+07 829406 1.18087e+06 8.15543e+06 3.07975e+07
76294 20230922.5 0.788097 17369.6 45706.4 47552.9 17271 18550.8 4429.35 3708.08 3775.04 5575.64 8.59996e+07 44082.6 14005.6 1.67936e+07 14188.9 1.05021e+07 6895.21 1.88908e+07 7197.1 6.30784e+06 1458.61 1.05021e+07 1282.38 1.05021e+07 1292.08 1.05021e+07 826220 1.18047e+06 8.16841e+06 3.09478e+07

images

@achamayou achamayou merged commit e4eaf38 into microsoft:release/4.x Sep 22, 2023
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyashton eddyashton eddyashton approved these changes

Assignees
No one assigned
Labels
4.x-backport Highlights PRs targeting the 4.x branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achamayou @eddyashton