From d60081150a4a96714c3779d778cc81c2f5674d52 Mon Sep 17 00:00:00 2001 From: Sergio Pedri Date: Tue, 9 Jul 2024 08:55:56 -0700 Subject: [PATCH] Add missing 'readonly' modifiers (#1664) --- .../GenericVtableInitializerStrings.cs | 36 +++++++++---------- .../StreamTaskAdaptersImplementation.cs | 18 +++++----- 2 files changed, 27 insertions(+), 27 deletions(-) diff --git a/src/Authoring/WinRT.SourceGenerator/GenericVtableInitializerStrings.cs b/src/Authoring/WinRT.SourceGenerator/GenericVtableInitializerStrings.cs index bac3c8445..08bfc5dab 100644 --- a/src/Authoring/WinRT.SourceGenerator/GenericVtableInitializerStrings.cs +++ b/src/Authoring/WinRT.SourceGenerator/GenericVtableInitializerStrings.cs @@ -192,7 +192,7 @@ private static string GetIEnumerableInstantiation(string genericType, string abi string iEnumerableInstantiation = $$""" internal static class IEnumerable_{{GeneratorHelper.EscapeTypeNameForIdentifier(genericType)}} { - private static bool _initialized = Init(); + private static readonly bool _initialized = Init(); internal static bool Initialized => _initialized; private static unsafe bool Init() @@ -228,7 +228,7 @@ private static string GetIEnumeratorInstantiation(string genericType, string abi string iEnumeratorInstantiation = $$""" internal static class IEnumerator_{{GeneratorHelper.EscapeTypeNameForIdentifier(genericType)}} { - private static bool _initialized = Init(); + private static readonly bool _initialized = Init(); internal static bool Initialized => _initialized; private static unsafe bool Init() @@ -332,7 +332,7 @@ private static string GetIListInstantiation(string genericType, string abiType, string iListInstantiation = $$""" internal static class IList_{{GeneratorHelper.EscapeTypeNameForIdentifier(genericType)}} { - private static bool _initialized = Init(); + private static readonly bool _initialized = Init(); internal static bool Initialized => _initialized; private static unsafe bool Init() @@ -569,7 +569,7 @@ private static string GetIReadOnlyListInstantiation(string genericType, string a string iReadOnlylistInstantiation = $$""" internal static class IReadOnlyList_{{GeneratorHelper.EscapeTypeNameForIdentifier(genericType)}} { - private static bool _initialized = Init(); + private static readonly bool _initialized = Init(); internal static bool Initialized => _initialized; private static unsafe bool Init() @@ -674,7 +674,7 @@ private static string GetIDictionaryInstantiation(string genericKeyType, string string iDictionaryInstantiation = $$""" internal static class IDictionary_{{GeneratorHelper.EscapeTypeNameForIdentifier(genericKeyType)}}_{{GeneratorHelper.EscapeTypeNameForIdentifier(genericValueType)}} { - private static bool _initialized = Init(); + private static readonly bool _initialized = Init(); internal static bool Initialized => _initialized; private static unsafe bool Init() @@ -829,7 +829,7 @@ private static string GetIReadOnlyDictionaryInstantiation(string genericKeyType, string iReadOnlyDictionaryInstantiation = $$""" internal static class IReadOnlyDictionary_{{GeneratorHelper.EscapeTypeNameForIdentifier(genericKeyType)}}_{{GeneratorHelper.EscapeTypeNameForIdentifier(genericValueType)}} { - private static bool _initialized = Init(); + private static readonly bool _initialized = Init(); internal static bool Initialized => _initialized; private static unsafe bool Init() @@ -933,7 +933,7 @@ private static string GetKeyValuePairInstantiation(string genericKeyType, string string keyValuePairInstantiation = $$""" internal static class KeyValuePair_{{GeneratorHelper.EscapeTypeNameForIdentifier(genericKeyType)}}_{{GeneratorHelper.EscapeTypeNameForIdentifier(genericValueType)}} { - private static bool _initialized = Init(); + private static readonly bool _initialized = Init(); internal static bool Initialized => _initialized; private static unsafe bool Init() @@ -990,7 +990,7 @@ private static string GetEventHandlerInstantiation(string genericType, string ab string eventHandlerInstantiation = $$""" internal static class EventHandler_{{GeneratorHelper.EscapeTypeNameForIdentifier(genericType)}} { - private static bool _initialized = Init(); + private static readonly bool _initialized = Init(); internal static bool Initialized => _initialized; private static unsafe bool Init() @@ -1048,7 +1048,7 @@ private static string GetTypedEventHandlerInstantiation(EquatableArray _initialized; private static unsafe bool Init() @@ -1106,7 +1106,7 @@ private static string GetCompletedHandlerInstantiation(string completedHandler, string completedHandlerInstantiation = $$""" internal static class {{completedHandler.Split('.')[^1]}}_{{GetGenericParametersAsString(genericParameters, "_", false)}} { - private static bool _initialized = Init(); + private static readonly bool _initialized = Init(); internal static bool Initialized => _initialized; private static unsafe bool Init() @@ -1141,7 +1141,7 @@ private static string GetChangedHandlerInstantiation(string changedHandler, stri string changedHandlerInstantiation = $$""" internal static class {{changedHandler.Split('.')[^1]}}_{{GetGenericParametersAsString(genericParameters, "_", false)}} { - private static bool _initialized = Init(); + private static readonly bool _initialized = Init(); internal static bool Initialized => _initialized; private static unsafe bool Init() @@ -1179,7 +1179,7 @@ private static string GetProgressHandlerInstantiation(string progressHandler, st string progressHandlerInstantiation = $$""" internal static class {{progressHandler.Split('.')[^1]}}_{{GetGenericParametersAsString(genericParameters, "_", false)}} { - private static bool _initialized = Init(); + private static readonly bool _initialized = Init(); internal static bool Initialized => _initialized; private static unsafe bool Init() @@ -1238,7 +1238,7 @@ private static string GetIAsyncActionWithProgressInstantiation(EquatableArray _initialized; private static unsafe bool Init() @@ -1353,7 +1353,7 @@ private static string GetIAsyncOperationWithProgressInstantiation(EquatableArray string instantiation = $$""" internal static class IAsyncOperationWithProgress_{{GetGenericParametersAsString(genericParameters, "_", false)}} { - private static bool _initialized = Init(); + private static readonly bool _initialized = Init(); internal static bool Initialized => _initialized; private static unsafe bool Init() @@ -1473,7 +1473,7 @@ private static string GetIAsyncOperationInstantiation(EquatableArray _initialized; private static unsafe bool Init() @@ -1553,7 +1553,7 @@ private static string GetIMapChangedEventArgsInstantiation(EquatableArray _initialized; private static unsafe bool Init() @@ -1612,7 +1612,7 @@ private static string GetIObservableMapInstantiation(EquatableArray _initialized; private static unsafe bool Init() @@ -1666,7 +1666,7 @@ private static string GetIObservableVectorInstantiation(EquatableArray _initialized; private static unsafe bool Init() diff --git a/src/cswinrt/strings/additions/Windows.Storage.Streams/StreamTaskAdaptersImplementation.cs b/src/cswinrt/strings/additions/Windows.Storage.Streams/StreamTaskAdaptersImplementation.cs index 12078ed85..fc749742c 100644 --- a/src/cswinrt/strings/additions/Windows.Storage.Streams/StreamTaskAdaptersImplementation.cs +++ b/src/cswinrt/strings/additions/Windows.Storage.Streams/StreamTaskAdaptersImplementation.cs @@ -5,7 +5,7 @@ namespace Windows.Storage.Streams // one for the scenarios which are used by StreamOperationsImplementations for its task adapters. internal static class StreamTaskAdaptersImplementation { - private static bool _initialized = Init(); + private static readonly bool _initialized = Init(); internal static bool Initialized => _initialized; private static unsafe bool Init() @@ -97,7 +97,7 @@ private static string LookupRuntimeClassName(Type type) private static class IAsyncOperationWithProgress_uint_uint { - private static bool _initialized = Init(); + private static readonly bool _initialized = Init(); internal static bool Initialized => _initialized; private static unsafe bool Init() @@ -213,7 +213,7 @@ private static unsafe int Do_Abi_get_Completed_3(IntPtr thisPtr, IntPtr* __retur private static class AsyncOperationProgressHandler_uint_uint { - private static bool _initialized = Init(); + private static readonly bool _initialized = Init(); internal static bool Initialized => _initialized; private static unsafe bool Init() @@ -268,7 +268,7 @@ private static unsafe void Invoke(IObjectReference objRef, global::Windows.Found private static class AsyncOperationWithProgressCompletedHandler_uint_uint { - private static bool _initialized = Init(); + private static readonly bool _initialized = Init(); internal static bool Initialized => _initialized; private static unsafe bool Init() @@ -298,7 +298,7 @@ private static unsafe int Do_Abi_Invoke(IntPtr thisPtr, IntPtr asyncInfo, global private static class IAsyncOperationWithProgress_IBuffer_uint { - private static bool _initialized = Init(); + private static readonly bool _initialized = Init(); internal static bool Initialized => _initialized; private static unsafe bool Init() @@ -415,7 +415,7 @@ private static unsafe int Do_Abi_get_Completed_3(IntPtr thisPtr, IntPtr* __retur private static class AsyncOperationProgressHandler_IBuffer_uint { - private static bool _initialized = Init(); + private static readonly bool _initialized = Init(); internal static bool Initialized => _initialized; private static unsafe bool Init() @@ -473,7 +473,7 @@ private static unsafe void Invoke( private static class AsyncOperationWithProgressCompletedHandler_IBuffer_uint { - private static bool _initialized = Init(); + private static readonly bool _initialized = Init(); internal static bool Initialized => _initialized; private static unsafe bool Init() @@ -503,7 +503,7 @@ private static unsafe int Do_Abi_Invoke(IntPtr thisPtr, IntPtr asyncInfo, global private static class IAsyncOperation_bool { - private static bool _initialized = Init(); + private static readonly bool _initialized = Init(); internal static bool Initialized => _initialized; private static unsafe bool Init() @@ -575,7 +575,7 @@ private static unsafe int Do_Abi_get_Completed_1(IntPtr thisPtr, IntPtr* __retur private static class AsyncOperationCompletedHandler_bool { - private static bool _initialized = Init(); + private static readonly bool _initialized = Init(); internal static bool Initialized => _initialized; private static unsafe bool Init()