Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support latest changes in transformers #512

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 21 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
bfce3df
Unpin transformers version
loadams Jul 25, 2024
5ab2823
Merge branch 'main' into loadams/revert-pin-transformers
loadams Jul 25, 2024
afaa341
Test with transformers v4.43.0
loadams Jul 25, 2024
464a8cb
Merge branch 'main' into loadams/revert-pin-transformers
loadams Aug 14, 2024
b84f2bf
Merge branch 'main' into loadams/revert-pin-transformers
loadams Aug 26, 2024
e5379e0
Merge branch 'main' into loadams/revert-pin-transformers
loadams Sep 3, 2024
75aa836
Merge branch 'main' into loadams/revert-pin-transformers
loadams Oct 28, 2024
55c103a
Merge branch 'main' into loadams/revert-pin-transformers
loadams Oct 29, 2024
482bd6b
Test with latest transformers
loadams Oct 29, 2024
9f01d52
Merge branch 'main' into loadams/revert-pin-transformers
loadams Oct 30, 2024
8277c35
Merge branch 'main' into loadams/revert-pin-transformers
loadams Oct 30, 2024
30889fa
Merge branch 'main' into loadams/revert-pin-transformers
loadams Oct 30, 2024
5162950
Test pinning to 4.43.4
loadams Oct 31, 2024
0a38ecc
Update to latest transformers
loadams Oct 31, 2024
482f809
Update to version where only the zero-shot-image-classification fails
loadams Nov 7, 2024
a589683
Revert certain changes
loadams Nov 7, 2024
ec38d2a
Add other debugging
loadams Nov 7, 2024
dc3ff22
pre-commit
loadams Nov 7, 2024
1bfb57d
Confirm replacement of inference_pipeline.model with engine causes pr…
loadams Nov 8, 2024
6008aca
Formatting
loadams Nov 8, 2024
14279e2
yapf
loadams Nov 8, 2024
629c31b
Update code
loadams Nov 8, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/nv-v100-legacy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
- name: Install dependencies
run: |
pip install git+https://github.com/microsoft/DeepSpeed.git
pip install git+https://github.com/huggingface/transformers.git@v4.42.4
pip install git+https://github.com/huggingface/transformers.git@v4.43.4
pip install -U accelerate
ds_report

Expand Down
4 changes: 2 additions & 2 deletions mii/legacy/models/load_models.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,8 @@ def load_models(model_config):
config=inf_config)
if model_config.profile_model_time:
engine.profile_model_time()
if hasattr(inference_pipeline, "model"):
inference_pipeline.model = engine
#if hasattr(inference_pipeline, "model"):
#inference_pipeline.model = engine
loadams marked this conversation as resolved.
Show resolved Hide resolved

elif model_config.enable_zero:
ds_config = DeepSpeedConfig(model_config.ds_config)
Expand Down