State Machine Improvement #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Benchmark results of before vs. after. Run on Azure E32s v3, 32 CPUs, 256GiB mem with the FASTER YCSB benchmark. I am convinced that the performance differential is not more profound than natural performance fluctuation on the Azure machine. Observe that sometimes the new branch outperforms the master branch as well. |
…the original test the two guids are switched and nobody noticed...
badrishc
reviewed
Apr 7, 2020
badrishc
approved these changes
Apr 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Break up the large state machine function into different objects. This is just a draft. I will finish converting everything and writing up documentation in the next few days.