[C#] Add ConditionalCopyToTail #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
TedHartMS
commented
Mar 25, 2023
TedHartMS
commented
- Add ConditionalCopyToTail internal method to insert a record if it is not found in a later record; allows batching of multiple IOs
- Replace ReadFlags with ReadCopyOptions
- CompletePending* must also check to lock non-auxiliary records - Ephemeral locking must look for lock evictions as well - InternalLock must check for SpinWaitUntilRecordIsClosed - Replace oneMiss handling in InternalLock - EphemeralSUnlock must follow unlock failures - LockTable should have its own bufferPool - Ensure OnPagesClosed does eviction scans in address order
- Fix missing unlock of a Tombstoned record in InternalContinuePendingRead - Add more Asserts where ManualLocking requires a locked record - Update and remove obsolete comments
- Better checking on following records transferred from LockTable in InternalLock(unlock) - Add some additional comments
Fix debug assert logic
- Add KeyCode creation and sorting and methods public and internal - Remove unnecessary IsLocked (it does not make work with EphemeralOnly and SessionControlled may map to multiple keys) - More tests run now
…l and readcache insertions - improve readcache consistency checking - clear HasInMemoryLock when HeadAddress goes above srcRecord address following BlockAllocate - rename LockingMode.SessionControlled -> Mixed and other renaming for clarity - remove some unused methods - fix locking sequences in InternalContinuePendingR(ead|MW)
- Missing 'ref' on recordInfo var in FindAndUnlockTransferredRecord - Improve record allocation checking for below-HA in-memory source and RecordInfo lock clearing if so - Add LockCode to HashEntryInfo in DEBUG
… in the relevant case we just need to wait for ReadCacheEvict to complete.
- Add/Improve some ToString()s - Remove unused RecSrc.ClearSrc() - Rename to HasRecordInfoLock - Move ICPRead HandleImmediateRetryStatus outside the lock scope - Consoldiate EphemeralSUnlock(AfterPendingIO)
…of these in InternalXxx and handling of these in CompletePending*() and TryFindRecordInMemory.
- Also consistentize related param names for readcache and log search to minAddress.
…at make the inputSrc unnecessary.
- make searches after pendingIO completion non-inclusive of minAddress - Some ToString() and naming changes for consistency - Remove RecordInfo.IsValidUpdateOrLockSource (superseded by direct call to .IsClosed)
…llocate - Add some comments for SafeHeadAddress et al.
…ession implementations
- Remove unused ReadFlags.ResetModifiedBit
…rt)Action.NeedMoreSpace (this is the default 'false' behavior)
- CreateLogDevice errors on Windows if path > MAX_PATH minus room for segment#.
- More WIP on ConditionalInsert
…rifyInMemoryAddresses
- Make TryCopyToReadCache bool - Tighten up DetachAndReattachReadCacheChain - Other minor tweaks
badrishc
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.