Fix build warning (#462)

zhiyuanliang-ms · web-flow · commit 95e7833037a3 · 2024-06-20T13:42:33.000+08:00
* fix xunit1031 warning

* resolve nullable warning

* remove nullable

* revert change to RazorPages project
diff --git a/examples/ConsoleApp/ConsoleApp.csproj b/examples/ConsoleApp/ConsoleApp.csproj
@@ -4,7 +4,6 @@
     <OutputType>Exe</OutputType>
     <TargetFramework>net6.0</TargetFramework>
     <ImplicitUsings>enable</ImplicitUsings>
-    <Nullable>enable</Nullable>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/examples/FeatureFlagDemo/FeatureFlagDemo.csproj b/examples/FeatureFlagDemo/FeatureFlagDemo.csproj
@@ -2,7 +2,6 @@
 
   <PropertyGroup>
     <TargetFramework>net6.0</TargetFramework>
-    <Nullable>enable</Nullable>
     <ImplicitUsings>enable</ImplicitUsings>
   </PropertyGroup>
 
diff --git a/examples/FeatureFlagDemo/Views/Shared/Error.cshtml.cs b/examples/FeatureFlagDemo/Views/Shared/Error.cshtml.cs
@@ -8,7 +8,7 @@ namespace FeatureFlagDemo.Pages.Shared
     [IgnoreAntiforgeryToken]
     public class ErrorModel : PageModel
     {
-        public string? RequestId { get; set; }
+        public string RequestId { get; set; }
 
         public bool ShowRequestId => !string.IsNullOrEmpty(RequestId);
 
diff --git a/examples/TargetingConsoleApp/TargetingConsoleApp.csproj b/examples/TargetingConsoleApp/TargetingConsoleApp.csproj
@@ -4,7 +4,6 @@
     <OutputType>Exe</OutputType>
     <TargetFramework>net6.0</TargetFramework>
     <ImplicitUsings>enable</ImplicitUsings>
-    <Nullable>enable</Nullable>
   </PropertyGroup>
   
   <ItemGroup>
diff --git a/tests/Tests.FeatureManagement/FeatureManagement.cs b/tests/Tests.FeatureManagement/FeatureManagement.cs
@@ -752,11 +752,11 @@ public async Task ThreadsafeSnapshot()
 
             await Task.WhenAll(tasks);
 
-            bool result = tasks.First().Result;
+            bool result = await tasks.First();
 
             foreach (Task<bool> t in tasks)
             {
-                Assert.Equal(result, t.Result);
+                Assert.Equal(result, await t);
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ namespace FeatureFlagDemo.Pages.Shared`
`8`	`8`	`[IgnoreAntiforgeryToken]`
`9`	`9`	`public class ErrorModel : PageModel`
`10`	`10`	`{`
`11`		`- public string? RequestId { get; set; }`
	`11`	`+ public string RequestId { get; set; }`
`12`	`12`
`13`	`13`	`public bool ShowRequestId => !string.IsNullOrEmpty(RequestId);`
`14`	`14`
Original file line number	Diff line number	Diff line change
`@@ -752,11 +752,11 @@ public async Task ThreadsafeSnapshot()`
`752`	`752`
`753`	`753`	`await Task.WhenAll(tasks);`
`754`	`754`
`755`		`- bool result = tasks.First().Result;`
	`755`	`+ bool result = await tasks.First();`
`756`	`756`
`757`	`757`	`foreach (Task<bool> t in tasks)`
`758`	`758`	`{`
`759`		`- Assert.Equal(result, t.Result);`
	`759`	`+ Assert.Equal(result, await t);`
`760`	`760`	`}`
`761`	`761`	`}`
`762`	`762`