Update README to emphasize built-in filters are add automatically and adjust wording #448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Should we update the release notes as well to call this a breaking change? Or adjust the AddFeatureFilter to TryAdd instead of Add and do a patch? |
Member
|
This is not intended breaking change (I suppose). If so, we should fix it ASAP. Adding it to the release notes will make it sound intentional. |
Member
Author
@zhenlan I have discussed with Jimmy. I will fix it ASAP. |
jimmyca15
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this PR?
#447
Azure/azure-sdk-for-java#40093 (comment)
Also include a small change to remove an unused reference in this PR
Visible changes
Update README
Remove an unused reference