From 7c63a217af65bf96ed63ca57db393cb44b11031d Mon Sep 17 00:00:00 2001 From: Matt Metcalf Date: Tue, 27 Aug 2024 13:48:10 -0700 Subject: [PATCH] Removing Configuration Reference --- featuremanagement/_featuremanagerbase.py | 5 +---- featuremanagement/_models/_constants.py | 1 - featuremanagement/_models/_variant_reference.py | 14 +------------- samples/formatted_feature_flags.json | 1 - 4 files changed, 2 insertions(+), 19 deletions(-) diff --git a/featuremanagement/_featuremanagerbase.py b/featuremanagement/_featuremanagerbase.py index 1dc83ff..4c683c0 100644 --- a/featuremanagement/_featuremanagerbase.py +++ b/featuremanagement/_featuremanagerbase.py @@ -211,10 +211,7 @@ def _variant_name_to_variant(self, feature_flag: FeatureFlag, variant_name: Opti return None for variant_reference in feature_flag.variants: if variant_reference.name == variant_name: - configuration = variant_reference.configuration_value - if not configuration and variant_reference.configuration_reference: - configuration = self._configuration.get(variant_reference.configuration_reference) - return Variant(variant_reference.name, configuration) + return Variant(variant_reference.name, variant_reference.configuration_value) return None def _build_targeting_context(self, args: Tuple[Any]) -> TargetingContext: diff --git a/featuremanagement/_models/_constants.py b/featuremanagement/_models/_constants.py index 3f6ca41..dd5ea35 100644 --- a/featuremanagement/_models/_constants.py +++ b/featuremanagement/_models/_constants.py @@ -30,5 +30,4 @@ # Variant Reference VARIANT_REFERENCE_NAME = "name" CONFIGURATION_VALUE = "configuration_value" -CONFIGURATION_REFERENCE = "configuration_reference" STATUS_OVERRIDE = "status_override" diff --git a/featuremanagement/_models/_variant_reference.py b/featuremanagement/_models/_variant_reference.py index afcab33..a9a660c 100644 --- a/featuremanagement/_models/_variant_reference.py +++ b/featuremanagement/_models/_variant_reference.py @@ -6,7 +6,7 @@ from dataclasses import dataclass from typing import Optional, Mapping, Any from typing_extensions import Self -from ._constants import VARIANT_REFERENCE_NAME, CONFIGURATION_VALUE, CONFIGURATION_REFERENCE, STATUS_OVERRIDE +from ._constants import VARIANT_REFERENCE_NAME, CONFIGURATION_VALUE, STATUS_OVERRIDE @dataclass @@ -18,7 +18,6 @@ class VariantReference: def __init__(self) -> None: self._name = None self._configuration_value = None - self._configuration_reference = None self._status_override = None @classmethod @@ -33,7 +32,6 @@ def convert_from_json(cls, json: Mapping[str, Any]) -> Self: variant_reference = cls() variant_reference._name = json.get(VARIANT_REFERENCE_NAME) variant_reference._configuration_value = json.get(CONFIGURATION_VALUE) - variant_reference._configuration_reference = json.get(CONFIGURATION_REFERENCE) variant_reference._status_override = json.get(STATUS_OVERRIDE, None) return variant_reference @@ -57,16 +55,6 @@ def configuration_value(self) -> Optional[str]: """ return self._configuration_value - @property - def configuration_reference(self) -> Optional[str]: - """ - Get the configuration reference for the variant. - - :return: Configuration reference for the variant. - :rtype: str - """ - return self._configuration_reference - @property def status_override(self) -> Optional[str]: """ diff --git a/samples/formatted_feature_flags.json b/samples/formatted_feature_flags.json index e541f2b..f3f278f 100644 --- a/samples/formatted_feature_flags.json +++ b/samples/formatted_feature_flags.json @@ -218,7 +218,6 @@ }, { "name": "False_Override", - "configuration_reference": "false-override", "status_override": "True" } ]