From f6829e78e387794a6d35ada7d566e7555639a91a Mon Sep 17 00:00:00 2001 From: Helio Liu <59622401+heliocliu@users.noreply.github.com> Date: Fri, 6 Aug 2021 17:02:04 -0700 Subject: [PATCH] Remove audience error logging in container (#7014) Fixes #6910 We're frequently hitting the race condition on initial connection (such as with transition from read to write client) where a client disconnects very close to when another client connects, and the disconnect audience signal is sent to the connecting client that never knew about the disconnecting client. This is obfuscating what we really want to check (mismatched audience join/leaves e.g. legitimately lost signals), so just remove it because it's nbd(TM) (jk see the attached bug for more info) --- packages/loader/container-loader/src/container.ts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/packages/loader/container-loader/src/container.ts b/packages/loader/container-loader/src/container.ts index bef1777925c6..48949891c2f0 100644 --- a/packages/loader/container-loader/src/container.ts +++ b/packages/loader/container-loader/src/container.ts @@ -1779,9 +1779,7 @@ export class Container extends EventEmitterWithErrorHandling i this._audience.addMember(newClient.clientId, newClient.client); } else if (innerContent.type === MessageType.ClientLeave) { const leftClientId = innerContent.content as string; - if (!this._audience.removeMember(leftClientId)) { - this.logger.sendErrorEvent({ eventName: "MissingAudienceMember", clientId: leftClientId }); - } + this._audience.removeMember(leftClientId); } } else { const local = this.clientId === message.clientId;