From e9adaac1b6628351ae74915344852b51652a826c Mon Sep 17 00:00:00 2001 From: Matt Rakow Date: Thu, 9 Jan 2025 10:11:25 -0800 Subject: [PATCH] Remove duplicative definition of getGCData --- .../api-report/shared-object-base.legacy.alpha.api.md | 1 - packages/dds/shared-object-base/src/sharedObject.ts | 4 ++-- packages/dds/shared-object-base/src/types.ts | 8 -------- .../api-report/fluid-framework.legacy.alpha.api.md | 1 - 4 files changed, 2 insertions(+), 12 deletions(-) diff --git a/packages/dds/shared-object-base/api-report/shared-object-base.legacy.alpha.api.md b/packages/dds/shared-object-base/api-report/shared-object-base.legacy.alpha.api.md index 4eab532dc67f..0768426d83db 100644 --- a/packages/dds/shared-object-base/api-report/shared-object-base.legacy.alpha.api.md +++ b/packages/dds/shared-object-base/api-report/shared-object-base.legacy.alpha.api.md @@ -15,7 +15,6 @@ export interface IFluidSerializer { // @alpha export interface ISharedObject extends IChannel, IEventProvider { bindToContext(): void; - getGCData(fullGC?: boolean): IGarbageCollectionData; } // @alpha diff --git a/packages/dds/shared-object-base/src/sharedObject.ts b/packages/dds/shared-object-base/src/sharedObject.ts index 640e9ffad163..28c93463869e 100644 --- a/packages/dds/shared-object-base/src/sharedObject.ts +++ b/packages/dds/shared-object-base/src/sharedObject.ts @@ -353,7 +353,7 @@ export abstract class SharedObjectCore< ): Promise; /** - * {@inheritDoc (ISharedObject:interface).getGCData} + * {@inheritDoc @fluidframework/datastore-definitions#(IChannel:interface).getGCData} */ public abstract getGCData(fullGC?: boolean): IGarbageCollectionData; @@ -766,7 +766,7 @@ export abstract class SharedObject< } /** - * {@inheritDoc (ISharedObject:interface).getGCData} + * {@inheritDoc @fluidframework/datastore-definitions#(IChannel:interface).getGCData} */ public getGCData(fullGC: boolean = false): IGarbageCollectionData { // Set _isGCing to true. This flag is used to ensure that we only use SummarySerializer to serialize handles diff --git a/packages/dds/shared-object-base/src/types.ts b/packages/dds/shared-object-base/src/types.ts index edaba0082e70..e5c4f49f7f3d 100644 --- a/packages/dds/shared-object-base/src/types.ts +++ b/packages/dds/shared-object-base/src/types.ts @@ -10,7 +10,6 @@ import { } from "@fluidframework/core-interfaces"; import { IChannel } from "@fluidframework/datastore-definitions/internal"; import { ISequencedDocumentMessage } from "@fluidframework/driver-definitions/internal"; -import { IGarbageCollectionData } from "@fluidframework/runtime-definitions/internal"; /** * Events emitted by {@link ISharedObject}. @@ -66,11 +65,4 @@ export interface ISharedObject extends IChannel, IEventProvider { bindToContext(): void; - getGCData(fullGC?: boolean): IGarbageCollectionData; } // @alpha