From 04a488bbb1787fa47132be0e70638bf30b6c5a59 Mon Sep 17 00:00:00 2001 From: James Lamb Date: Thu, 28 Oct 2021 12:29:55 -0500 Subject: [PATCH 1/3] [docs] [R-package] update cran-comments for v3.3.1 release --- R-package/cran-comments.md | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/R-package/cran-comments.md b/R-package/cran-comments.md index 8d9672e9d5a7..e145118de51a 100644 --- a/R-package/cran-comments.md +++ b/R-package/cran-comments.md @@ -1,11 +1,25 @@ # CRAN Submission History -## v3.3.1 - Submission 1 - (TBD) +## v3.3.1 - Submission 1 - (October 27, 2021) ### CRAN response ### Maintainer Notes +Submitted v3.3.1 to CRAN, with the following fixes for the issues that caused CRAN to reject v3.3.0 and archive the package: + +* https://github.com/microsoft/LightGBM/pull/4673 +* https://github.com/microsoft/LightGBM/pull/4714 + +Submitted with the following comment: + +> This submission contains {lightgbm} 3.3.1. +> Per CRAN's policies, I am submitting on it on behalf of the project's maintainer (Yu Shi), with his permission (https://github.com/microsoft/LightGBM/pull/4715#issuecomment-952537783). + +> {lightgbm} was removed from CRAN on October 25, 2021 due to issues detected in the gcc-ASAN and cran-ASAN checks. To the best of our knowledge, we believe this release fixes those issues. We have introduced automated testing that we believe faithfully reproduces CRAN's tests with sanitizers (https://github.com/microsoft/LightGBM/pull/4678). + +> Thank you very much for your time and consideration. + ## v3.3.0 - Submission 1 - (October 8, 2021) ### CRAN response From 19667a24a02d903317cca404cd05d09af0fecc2b Mon Sep 17 00:00:00 2001 From: James Lamb Date: Thu, 28 Oct 2021 15:16:10 -0500 Subject: [PATCH 2/3] Update R-package/cran-comments.md Co-authored-by: Nikita Titov --- R-package/cran-comments.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/R-package/cran-comments.md b/R-package/cran-comments.md index e145118de51a..ffbed403b1a2 100644 --- a/R-package/cran-comments.md +++ b/R-package/cran-comments.md @@ -16,7 +16,7 @@ Submitted with the following comment: > This submission contains {lightgbm} 3.3.1. > Per CRAN's policies, I am submitting on it on behalf of the project's maintainer (Yu Shi), with his permission (https://github.com/microsoft/LightGBM/pull/4715#issuecomment-952537783). -> {lightgbm} was removed from CRAN on October 25, 2021 due to issues detected in the gcc-ASAN and cran-ASAN checks. To the best of our knowledge, we believe this release fixes those issues. We have introduced automated testing that we believe faithfully reproduces CRAN's tests with sanitizers (https://github.com/microsoft/LightGBM/pull/4678). +> {lightgbm} was removed from CRAN on October 25, 2021 due to issues detected in the gcc-ASAN and clang-ASAN checks. To the best of our knowledge, we believe this release fixes those issues. We have introduced automated testing that we believe faithfully reproduces CRAN's tests with sanitizers (https://github.com/microsoft/LightGBM/pull/4678). > Thank you very much for your time and consideration. From ec57de0a9a7f4ef76eff9c9a285ac5861a9c285e Mon Sep 17 00:00:00 2001 From: James Lamb Date: Sat, 6 Nov 2021 21:28:59 -0500 Subject: [PATCH 3/3] update cran-comments.md now that v3.3.1 is accepted --- R-package/cran-comments.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/R-package/cran-comments.md b/R-package/cran-comments.md index ffbed403b1a2..1d354cfa3777 100644 --- a/R-package/cran-comments.md +++ b/R-package/cran-comments.md @@ -4,6 +4,10 @@ ### CRAN response +Accepted to CRAN on October 30, 2021. + +CRAN completed its checks and preparation of binaries on November 6, 2021. + ### Maintainer Notes Submitted v3.3.1 to CRAN, with the following fixes for the issues that caused CRAN to reject v3.3.0 and archive the package: @@ -20,6 +24,8 @@ Submitted with the following comment: > Thank you very much for your time and consideration. +Progress on the submission was tracked in https://github.com/microsoft/LightGBM/issues/4713. + ## v3.3.0 - Submission 1 - (October 8, 2021) ### CRAN response