Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mixed numeric datatypes for optimizers #667

Merged
merged 15 commits into from
Feb 7, 2024
Merged

Fix mixed numeric datatypes for optimizers #667

merged 15 commits into from
Feb 7, 2024

Commits on Feb 5, 2024

  1. [Fix] Add fix for pandas.Dataframe.iterrows() dropping dtypes during … 

    …conversion
    @ephoris
    ephoris committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    0eafaf0 View commit details
    Browse the repository at this point in the history

  2. [WIP] Add test for mixed input spaces

    @ephoris
    ephoris committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    8395321 View commit details
    Browse the repository at this point in the history

  3. [WIP] Change suggestion building in pytest example 

    Note that if you have a dataframe will all numeric types, df.iloc[0] will convert all columns to float64 because Series cannot be mixed type.
    @ephoris
    ephoris committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    71afa15 View commit details
    Browse the repository at this point in the history

  4. [Fix] Change iterrows to itertuples to preserve datatypes in numeric … 

    …dataframes
    @ephoris
    ephoris committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    9f129a5 View commit details
    Browse the repository at this point in the history

  5. Revert "[WIP] Change suggestion building in pytest example" 

    This reverts commit 6c3a482.
    @ephoris
    ephoris committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    55bf6b3 View commit details
    Browse the repository at this point in the history

  6. [Test] Change suggestion building in pytest example"" 

    This reverts commit 55bf6b3.
Realized this is required as again, df.iloc[0] will convert all items to a similar type because pandas.Series cannot be mixed types. In the case of numeric values, everything is implicitly translated into numpy.float64 types.
    @ephoris
    ephoris committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    8d1ef69 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. Update mlos_core/mlos_core/spaces/adapters/llamatune.py 

    Co-authored-by: Sergiy Matusevych <sergiy.matusevych@gmail.com>
    @ephoris @motus
    ephoris and motus authored Feb 6, 2024
    Configuration menu
    Copy the full SHA
    bd272c8 View commit details
    Browse the repository at this point in the history

  2. [Revert] Copyright lines removed by mistake

    @ephoris
    ephoris committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    617afe9 View commit details
    Browse the repository at this point in the history

  3. [Fix] Revert to iterrows, but typecast dataframe to object type

    @ephoris
    ephoris committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    983763f View commit details
    Browse the repository at this point in the history

  4. [Test] Fix tagging on args

    @ephoris
    ephoris committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    ff33ce4 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Merge branch 'main' into ephoris/smac/iter_bug

    @ephoris
    ephoris authored Feb 7, 2024
    Configuration menu
    Copy the full SHA
    6c6a30a View commit details
    Browse the repository at this point in the history

  2. Update mlos_core/mlos_core/tests/optimizers/optimizer_test.py 

    Co-authored-by: Brian Kroth <bpkroth@users.noreply.github.com>
    @ephoris @bpkroth
    ephoris and bpkroth authored Feb 7, 2024
    Configuration menu
    Copy the full SHA
    4b4ec33 View commit details
    Browse the repository at this point in the history

  3. Update mlos_core/mlos_core/tests/optimizers/optimizer_test.py 

    Co-authored-by: Brian Kroth <bpkroth@users.noreply.github.com>
    @ephoris @bpkroth
    ephoris and bpkroth authored Feb 7, 2024
    Configuration menu
    Copy the full SHA
    423d582 View commit details
    Browse the repository at this point in the history

  4. [Test] Clean optimizer_test to include seed and checks

    @ephoris
    ephoris committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    2bc2e50 View commit details
    Browse the repository at this point in the history

  5. Update mlos_core/mlos_core/tests/optimizers/optimizer_test.py

    @bpkroth
    bpkroth authored Feb 7, 2024
    Configuration menu
    Copy the full SHA
    05becea View commit details
    Browse the repository at this point in the history