Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing tweaks #696

Merged
merged 12 commits into from
Mar 6, 2024
Merged

Typing tweaks #696

merged 12 commits into from
Mar 6, 2024

Conversation

bpkroth
Copy link
Contributor

@bpkroth bpkroth commented Mar 4, 2024

Some type hint and alias tweaks for Tunables and a few others.

Split off from #690.

@bpkroth bpkroth requested a review from a team as a code owner March 4, 2024 18:33
@bpkroth bpkroth added the ready for review Ready for review label Mar 4, 2024
@bpkroth bpkroth enabled auto-merge (squash) March 4, 2024 19:22
Copy link
Member

@motus motus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left one small comment, but I'm ambivalent on this one

mlos_bench/mlos_bench/storage/util.py Outdated Show resolved Hide resolved
@bpkroth bpkroth merged commit 5d83f55 into microsoft:main Mar 6, 2024
12 checks passed
@bpkroth bpkroth deleted the typing-tweaks branch March 6, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants