New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing 'shell_env_params' in redis.jsonc #754

Merged

bpkroth merged 1 commit into microsoft:main from DelphianCalamity:redis-bench-fix

Jun 12, 2024

Contributor

DelphianCalamity commented Jun 12, 2024

These missing environment variables were causing the Redis benchmark to fail.


          fix in redis.jsonc

178d9a5

DelphianCalamity requested a review from a team as a code owner

June 12, 2024 03:12

bpkroth approved these changes

View reviewed changes

Contributor

bpkroth left a comment

LGTM, thanks!
We'll eventually need to add end-to-end tests in #332, but not here.

bpkroth enabled auto-merge (squash)

June 12, 2024 16:45

bpkroth merged commit ecfb5be into microsoft:main

12 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet