This repository has been archived by the owner on Jun 14, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 114
Show device tracking status to the user on mobile devices and cleanup UI #223
Merged
+2,817
−826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rvers for tracking reporting
chrisfromwork
added
the
breaking change
Pull request contains a breaking change and requires additional information.
label
Sep 23, 2019
chrisfromwork
requested review from
andreiborodin,
matthejo,
fibann,
stephenatwork and
wiwei
September 23, 2019 22:00
…rlay when things are in a bad state
matthejo
reviewed
Sep 25, 2019
matthejo
reviewed
Sep 25, 2019
src/SpectatorView.Unity/Assets/SpectatorView.Editor/Scripts/CompositorWindowBase.cs
Outdated
Show resolved
Hide resolved
If UNITY_EDITOR is true, will this produce a warning about unreachable code? might be worth putting all of this in an #else block Refers to: src/SpectatorView.Unity/Assets/SpectatorView/Scripts/ScreenRecording/AndroidRecordingService.cs:157 in 45c53e8. [](commit_id = 45c53e8, deletion_comment = False) |
matthejo
reviewed
Sep 25, 2019
...orView.Unity/Assets/SpectatorView/Scripts/SpatialAlignment/SpatialCoordinateSystemManager.cs
Outdated
Show resolved
Hide resolved
matthejo
reviewed
Sep 25, 2019
...orView.Unity/Assets/SpectatorView/Scripts/SpatialAlignment/SpatialCoordinateSystemManager.cs
Outdated
Show resolved
Hide resolved
matthejo
reviewed
Sep 25, 2019
...ew.Unity/Assets/SpectatorView/Scripts/SpatialAlignment/SpatialCoordinateSystemParticipant.cs
Outdated
Show resolved
Hide resolved
matthejo
reviewed
Sep 25, 2019
src/SpectatorView.Unity/Assets/SpectatorView.Editor/Scripts/CompositorWindowBase.cs
Outdated
Show resolved
Hide resolved
matthejo
reviewed
Sep 25, 2019
src/SpectatorView.Unity/Assets/SpectatorView.Helpers/Scripts/ARKitTrackingObserver.cs
Show resolved
Hide resolved
...orView.Unity/Assets/SpectatorView/Scripts/SpatialAlignment/SpatialCoordinateSystemManager.cs
Outdated
Show resolved
Hide resolved
andreiborodin
approved these changes
Oct 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been some confusion around tracking/not tracking and marker detection logic. This review is a first attempt to try and mitigate these issues. It contains the following:
Tracking:
UI Improvements:
Breaking Change Details:
Notes:
This change has two primary breaking changes.
Migration Instructions:
Any references to
Mobile Recording Service Visual
andMobile Network Configuration Visual
will need to be updated toDefault Mobile UI
andDefault Mobile Network Configuration Visual
. Code changes may be required if any of the SpectatorView\Scripts\UI scripts were referenced/used outside of these prefabs.HolographicCamera.Unity will need to be recompiled/deployed for tracking/spatial coordinate information to be correctly reported to the spectator view compositor. This now uses the ITrackingObserver MonoBehaviour.