Populate document outline with all symbols, not just top level #4624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zooba
approved these changes
Aug 10, 2018
| var res = analysis.GetAllAvailableMembersFromScope(scope, opts).Concat(GetChildScopesVariables(analysis, scope, opts)); | ||
| foreach (var m in res) { | ||
| yield return m; | ||
| } |
| foreach (var childScope in scope.Children) { | ||
| var res = GetScopeVariables(analysis, childScope, opts); | ||
| foreach (var m in res) { | ||
| yield return m; | ||
| } | ||
| } |
There was a problem hiding this comment.
return scope.Children.SelectMany(c => GetScopeVariables(analysis, c, opts))?
| kvp.Key, | ||
| null, | ||
| kvp.Value.Definitions.Select(e => e.GetLocationInfo()) | ||
| )); |
There was a problem hiding this comment.
Do we need this if there have been variables added? Or do we need it if the value has no definitions?
There was a problem hiding this comment.
It was existing code that applied to a single scope and now called for each scope recursively.
| @@ -133,6 +133,6 @@ class BuiltinNamespace<MemberContainerType> : AnalysisValue where MemberContaine | |||
| return false; | |||
| } | |||
|
|
|||
| public override int GetHashCode() => new { hc1 = GetType().GetHashCode(), hc2 = _type.GetHashCode() }.GetHashCode(); | |||
| public override int GetHashCode() => new { hc1 = GetType()?.GetHashCode() ?? 0, hc2 = _type?.GetHashCode() ?? 0 }.GetHashCode(); | |||
There was a problem hiding this comment.
Think I just saw a slightly different fix in another PR, but now I look at it, we shouldn't have to call GetHashCode() on the members here. The anonymous type GetHashCode will do it (and handle nulls properly)
added 2 commits
August 10, 2018 09:37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
microsoft/vscode-python#2334
microsoft/vscode-python#2050