-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve snapshotting #759
Comments
Hear, hear! Let's not snapshot them and let's not pretend that they are parameters. |
@WilliamHPNielsen Arrays are most definitely parameters! To give some concrete example: we use certain Lookuptable based devices where a parameter of the device is the content of one of these lookuptables. These are simple 1D arrays of varying size. |
@AdriaanRol, granted, that sounds like a parameter. But the stuff that currently goes into a |
@WilliamHPNielsen To be clear, we are using regular |
That is a longer discussion that will inevitably lead us into how we need to do a major rewiring of QCoDeS. For now, let me just say that this rewiring is on its way, and that we are thinking a lot about it here in Copenhagen. |
@jenshnielsen @WilliamHPNielsen I just updated to 0.1.7 for the option to exclude some parameters from the snapshot. However, I find that even though it is no longer queried it is still included in my snapshot. IMO it these kind of parameters should be excluded from the snapshot completely, as the main reason to omit them is to save time when running an experiment. This is ofcourse quite easy to implement (given the recent changes to |
I think there are two different use cases, of which we only really fix one (Why this issue exists) The QDac has 48 channels we like to include these in the snapshot but updating them individually is slow. This therefore allows us to skip the update of them individually and just call the get all parameters function once, thus reducing the time to update by a factor of 1/(3*48) (3 parameters per channel) The other use case is what you describe, I fully agree that should be solved in a better way. |
In other works we should push for a fix for this. Lets do that as soon as #600 lands |
I'm fairly sure #651 resolved this issue's original concern by introducing |
@WilliamHPNielsen and @jenshnielsen - can you confirm that the issue is resolved via #651? |
I think so |
As discussed in #758
Currently all parameters are snapshotted. As suggested by @AdriaanRol there should probably be a good way to turn off snapshotting per parameter without subclassing and perhaps snapshotting should be off by default for array and multiparameters. This again raises the question if Array/MultiParamers are really parameters at all
The text was updated successfully, but these errors were encountered: