Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin testpath to fix conda/pip issue #1298

Merged
merged 1 commit into from
Oct 5, 2018

Conversation

jenshnielsen
Copy link
Collaborator

Discovered as part of #1297 should unbreak a conda install for now

@codecov
Copy link

codecov bot commented Oct 4, 2018

Codecov Report

Merging #1298 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1298   +/-   ##
=======================================
  Coverage   72.54%   72.54%           
=======================================
  Files          74       74           
  Lines        8456     8456           
=======================================
  Hits         6134     6134           
  Misses       2322     2322

@jenshnielsen
Copy link
Collaborator Author

See conda-forge/testpath-feedstock#7 and pypa/pip#5839

It seems like a new version of test path was released on conda forge that contains invalid metadata which in turn makes pip give up and fail on any install

Copy link
Contributor

@WilliamHPNielsen WilliamHPNielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good idea.

@WilliamHPNielsen WilliamHPNielsen merged commit 5202255 into microsoft:master Oct 5, 2018
giulioungaretti pushed a commit that referenced this pull request Oct 5, 2018
Merge: 4db444d aae67df
Author: William H.P. Nielsen <whpn@mailbox.org>

    Merge pull request #1298 from jenshnielsen/fix_conda_testpath
@jenshnielsen jenshnielsen deleted the fix_conda_testpath branch October 5, 2018 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants