Implement P3567R2 flat_meow Fixes
#5882
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With additional condition fixes for `append_range`
frederick-vs-ja
force-pushed
the
p3567r2
branch
from
fe95990 to
9536d79
Compare
frederick-vs-ja
force-pushed
the
p3567r2
branch
from
9536d79 to
0593036
Compare
frederick-vs-ja
commented
Nov 19, 2025
| std/utilities/meta/meta.unary/meta.unary.prop/is_implicit_lifetime.pass.cpp:0 FAIL | ||
| std/utilities/meta/meta.unary/meta.unary.prop/is_implicit_lifetime.pass.cpp:1 FAIL | ||
|
|
||
| # MSVC has not implemented P2448R2 "Relaxing some constexpr restrictions" |
Contributor
Author
There was a problem hiding this comment.
Actually, failures under "FIXME! C++26 "P3372R3 constexpr Containers And Adaptors" isn't completely guarded with TEST_STD_VER >= 26." were also due to this.
Since C++23 (WG21-P2448R2), it's valid to mark the the test functions constexpr even though they never produce any constant (sub)expression in C++23 mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #2910 and #2912.
Implements Part
swapShould be Conditionallynoexceptinsert_range(sorted_unique, rg), andfrom WG21-P3567R2. Other parts are probably already implemented.
Drive-by changes:
[[msvc::no_unique_address]]toflat_meowin the feature.append_range- we may only rely it when it belongs to some standard containers.Blocked libcxx tests:
std/containers/container.adaptors/flat.map/flat.map.modifiers/swap_free.pass.cpp(testing old, overly strong exception specification)std/containers/container.adaptors/flat.map/flat.map.modifiers/swap_member.pass.cpp(same as above)std/containers/container.adaptors/flat.multimap/flat.multimap.modifiers/swap_free.pass.cpp(same as above)std/containers/container.adaptors/flat.multimap/flat.multimap.modifiers/swap_member.pass.cpp(same as above)std/containers/container.adaptors/flat.multiset/flat.multiset.modifiers/swap_free.pass.cpp(same as above)std/containers/container.adaptors/flat.multiset/flat.multiset.modifiers/swap_member.pass.cpp(same as above)std/containers/container.adaptors/flat.set/flat.set.modifiers/swap_free.pass.cpp(same as above)std/containers/container.adaptors/flat.set/flat.set.modifiers/swap_member.pass.cpp(same as above)std/language.support/support.limits/support.limits.general/flat_map.version.compile.pass.cpp(testing old FTM value)std/language.support/support.limits/support.limits.general/flat_set.version.compile.pass.cpp(same as above)Unblocked libcxx test:
std/containers/container.adaptors/flat.multiset/flat.multiset.modifiers/insert_range.pass.cpp(due to the drive-by fix)std/containers/container.adaptors/flat.set/flat.set.modifiers/insert_range.pass.cpp(same as above; but only for Clang, because MSVC hasn't implemented WG21-P2448R2)