From db9b74e5d521c37437948f1c822a11662946a998 Mon Sep 17 00:00:00 2001 From: Billy Robert O'Neal III Date: Thu, 26 Mar 2020 22:33:36 -0700 Subject: [PATCH 1/3] Remove out of date parts of the pull request template, and put instructions to pull request submitters in a comment rather than duplicating them into each PR. --- .github/pull_request_template.md | 39 ++++++++------------------------ 1 file changed, 10 insertions(+), 29 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index a04bf6cefc5..9b022dbbee2 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,29 +1,10 @@ -Description -=========== - - - -Checklist -========= - -Be sure you've read README.md and understand the scope of this repo. - -If you're unsure about a box, leave it unchecked. A maintainer will help you. - -- [ ] Identifiers in product code changes are properly `_Ugly` as per - https://eel.is/c++draft/lex.name#3.1 or there are no product code changes. -- [ ] The STL builds successfully and all tests have passed (must be manually - verified by an STL maintainer before automated testing is enabled on GitHub, - leave this unchecked for initial submission). -- [ ] These changes introduce no known ABI breaks (adding members, renaming - members, adding virtual functions, changing whether a type is an aggregate - or trivially copyable, etc.). -- [ ] These changes were written from scratch using only this repository, - the C++ Working Draft (including any cited standards), other WG21 papers - (excluding reference implementations outside of proposed standard wording), - and LWG issues as reference material. If they were derived from a project - that's already listed in NOTICE.txt, that's fine, but please mention it. - If they were derived from any other project (including Boost and libc++, - which are not yet listed in NOTICE.txt), you *must* mention it here, - so we can determine whether the license is compatible and what else needs - to be done. + From 6bdfa35d6e9d27878eba90f28df00cd39f374326 Mon Sep 17 00:00:00 2001 From: Billy Robert O'Neal III Date: Mon, 30 Mar 2020 21:56:22 -0700 Subject: [PATCH 2/3] Re-add bullets 1 and 3. --- .github/pull_request_template.md | 25 +++++++++++++++++-------- 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 9b022dbbee2..9332ac09f67 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,10 +1,19 @@ From 95567c9b9d8d22e3e451222bc2263a9918b4feee Mon Sep 17 00:00:00 2001 From: "Stephan T. Lavavej" Date: Wed, 1 Apr 2020 15:35:26 -0700 Subject: [PATCH 3/3] Use "are derived" consistently, drop "such as Boost". --- .github/pull_request_template.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 9332ac09f67..411e82a94bb 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -13,7 +13,7 @@ Before submitting a pull request, please ensure that: reference implementations outside of proposed standard wording), and LWG issues as reference material. If your changes are derived from a project that's already listed in NOTICE.txt, that's fine, but please mention it. - If your changes were derived from any other project (such as Boost), you - *must* mention it here, so we can determine whether the license is compatible - and what else needs to be done. + If your changes are derived from any other project, you *must* mention it + here, so we can determine whether the license is compatible and what else + needs to be done. -->