SVGStyleElement implements LinkStyle #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sandersn
requested changes
Oct 1, 2020
There was a problem hiding this comment.
- There are two copies of CSS.escape now, so one probably needs to be deleted.
- caniuse.com only lists Edge as supporting LinkStyle, but doesn't have information for other browsers. Can you figure out if it's available in Firefox or Safari, for example? We only want to add things that are supported by two or more browsers.
sandersn
requested changes
Oct 1, 2020
sandersn
approved these changes
Oct 2, 2020
|
Thanks @conniefan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SVGStyleElement implements LinkStyle, which will give it the 'sheet' property
microsoft/TypeScript#36896