Add resize observer #948
Merged
Add resize observer #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saschanaz
reviewed
Oct 26, 2020
saschanaz
reviewed
Oct 26, 2020
…e it's experimental at the moment
saschanaz
approved these changes
Oct 26, 2020
|
Thanks for being proactive and get things moving again. 👏 I'm looking forward to seeing this merged! Perhaps add some closing keywords in the PR description to close the other issue and the inactive PR once this one gets merged? |
This was referenced Nov 7, 2020
|
@sandersn can we merge this? |
Earlo
added a commit
to RikuLa/lucky-wheel
that referenced
this pull request
Nov 21, 2020
|
@saschanaz there's been a few releases since your previous comment, is there any update on when this will be merged? |
|
By new release I mean a new minor version bump. I don't have any further information unfortunately. |
a-tarasyuk
approved these changes
Dec 4, 2020
timocov
added a commit
to tradingview/lightweight-charts
that referenced
this pull request
Dec 10, 2020
sandersn
approved these changes
Dec 11, 2020
|
Just merged master branch with resolving conflicts. |
|
Thanks! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #847, but with replacing the
sequencetype withFrozenArray(see #847 (comment), #847 (comment), w3c/webidl2.js#392 (comment)).I'm not sure whether it's correct to do so in this way, but it seems that #847 is inactive so far and I'm not sure why we can't change the type according the drafts.
Please let me know if I did something wrong and/or close this PR if required.
fixes microsoft/TypeScript#37861
fixes #908