From 76b7d435fdbec8a4b88ac0b01b88e3fb72a829d1 Mon Sep 17 00:00:00 2001 From: Orta Date: Thu, 6 Aug 2020 12:06:10 -0400 Subject: [PATCH 1/2] Add import helpers to the playground config --- packages/playground/src/index.ts | 8 ++++---- packages/sandbox/src/compilerOptions.ts | 2 ++ packages/tsconfig-reference/scripts/tsconfigRules.ts | 1 - packages/typescriptlang-org/tsconfig.json | 1 + 4 files changed, 7 insertions(+), 5 deletions(-) diff --git a/packages/playground/src/index.ts b/packages/playground/src/index.ts index e60311762b17..51deaa8f951a 100644 --- a/packages/playground/src/index.ts +++ b/packages/playground/src/index.ts @@ -386,8 +386,8 @@ export const setupPlayground = ( } else { sidebarTabs.style.display = "none" sidebarContent.style.display = "none" - settingsContent.style.display = "block"; - (document.querySelector(".playground-sidebar label") as any).focus() + settingsContent.style.display = "block" + ;(document.querySelector(".playground-sidebar label") as any).focus() } settingsToggle.parentElement!.classList.toggle("open") } @@ -462,8 +462,8 @@ export const setupPlayground = ( } // Ensure that the editor is full-width when the screen resizes - window.addEventListener('resize', () => { - sandbox.editor.layout(); + window.addEventListener("resize", () => { + sandbox.editor.layout() }) const ui = createUI() diff --git a/packages/sandbox/src/compilerOptions.ts b/packages/sandbox/src/compilerOptions.ts index cdd0527b79e5..166ded63539e 100644 --- a/packages/sandbox/src/compilerOptions.ts +++ b/packages/sandbox/src/compilerOptions.ts @@ -40,6 +40,8 @@ export function getDefaultSandboxCompilerOptions(config: PlaygroundConfig, monac allowJs: config.useJavaScript, declaration: true, + importHelpers: false, + experimentalDecorators: true, emitDecoratorMetadata: true, moduleResolution: monaco.languages.typescript.ModuleResolutionKind.NodeJs, diff --git a/packages/tsconfig-reference/scripts/tsconfigRules.ts b/packages/tsconfig-reference/scripts/tsconfigRules.ts index 521c9c21fc70..ee6887881d7b 100644 --- a/packages/tsconfig-reference/scripts/tsconfigRules.ts +++ b/packages/tsconfig-reference/scripts/tsconfigRules.ts @@ -117,7 +117,6 @@ export const defaultsForOptions = { inlineSourceMap: "false", inlineSources: "false", isolatedModules: "false", - jsx: '`"react"`', jsxFactory: "`React.createElement`", keyofStringsOnly: "false", listEmittedFiles: "false", diff --git a/packages/typescriptlang-org/tsconfig.json b/packages/typescriptlang-org/tsconfig.json index 636824fe9e9e..722b9fe0b1a6 100644 --- a/packages/typescriptlang-org/tsconfig.json +++ b/packages/typescriptlang-org/tsconfig.json @@ -7,6 +7,7 @@ "strict": true, "esModuleInterop": true, "noEmit": true, + "jsx": "react", "skipLibCheck": true, "noImplicitAny": false, "resolveJsonModule": true From 1b050591230e76c3848ae3fc693d1481789c7a29 Mon Sep 17 00:00:00 2001 From: Orta Date: Thu, 6 Aug 2020 12:10:19 -0400 Subject: [PATCH 2/2] Supress the tslib not found diagnostic --- packages/sandbox/src/index.ts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/packages/sandbox/src/index.ts b/packages/sandbox/src/index.ts index b2c7dfa3475a..fbb88e8a44c1 100644 --- a/packages/sandbox/src/index.ts +++ b/packages/sandbox/src/index.ts @@ -150,7 +150,12 @@ export const createTypeScriptSandbox = ( ? monaco.languages.typescript.javascriptDefaults : monaco.languages.typescript.typescriptDefaults - defaults.setDiagnosticsOptions({ ...defaults.getDiagnosticsOptions(), noSemanticValidation: false }) + defaults.setDiagnosticsOptions({ + ...defaults.getDiagnosticsOptions(), + noSemanticValidation: false, + // This is when tslib is not found + diagnosticCodesToIgnore: [2354], + }) // In the future it'd be good to add support for an 'add many files' const addLibraryToRuntime = (code: string, path: string) => {