From 4c09fae11ccd06d0440c84969dc3ddc63cd65918 Mon Sep 17 00:00:00 2001 From: Jake Bailey <5341706+jakebailey@users.noreply.github.com> Date: Tue, 14 May 2024 19:15:44 -0700 Subject: [PATCH] Ignore all bots (#49) --- src/anyRepoHandlePullRequest.ts | 2 +- src/checks/addCommentToUncommittedPRs.test.ts | 2 +- src/checks/addCommentToUncommittedPRs.ts | 2 +- src/util/tests/createPRInfo.ts | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/anyRepoHandlePullRequest.ts b/src/anyRepoHandlePullRequest.ts index 320c0c3..4558200 100644 --- a/src/anyRepoHandlePullRequest.ts +++ b/src/anyRepoHandlePullRequest.ts @@ -64,7 +64,7 @@ const generatePRInfo = async (api: Octokit, payload: PullRequestEvent, logger: L return { thisIssue, authorIsMemberOfTSTeam, - authorIsTypescriptBot: payload.pull_request.user.login === "typescript-bot", + authorIsBot: payload.pull_request.user.type === "Bot", relatedIssues, comments } diff --git a/src/checks/addCommentToUncommittedPRs.test.ts b/src/checks/addCommentToUncommittedPRs.test.ts index 1312299..ff87706 100644 --- a/src/checks/addCommentToUncommittedPRs.test.ts +++ b/src/checks/addCommentToUncommittedPRs.test.ts @@ -32,7 +32,7 @@ describe(addCommentToUncommittedPRs, () => { const pr = getPRFixture("opened") pr.pull_request.user.login = "typescript-bot" - const info = createPRInfo({ authorIsTypescriptBot: true }) + const info = createPRInfo({ authorIsBot: true }) await addCommentToUncommittedPRs(api, pr, getFakeLogger(), info) expect(mockAPI.issues.createComment).not.toHaveBeenCalled() diff --git a/src/checks/addCommentToUncommittedPRs.ts b/src/checks/addCommentToUncommittedPRs.ts index 158efa9..02e2ace 100644 --- a/src/checks/addCommentToUncommittedPRs.ts +++ b/src/checks/addCommentToUncommittedPRs.ts @@ -7,7 +7,7 @@ import { Logger } from "../util/logger" * Comment on new PRs that don't have linked issues, or link to uncommitted issues. */ export const addCommentToUncommittedPRs = async (api: Octokit, payload: PullRequestEvent, logger: Logger, info: PRInfo) => { - if (payload.pull_request.merged || payload.pull_request.draft || info.authorIsMemberOfTSTeam || info.authorIsTypescriptBot) { + if (payload.pull_request.merged || payload.pull_request.draft || info.authorIsMemberOfTSTeam || info.authorIsBot) { return logger.trace("Skipping") } diff --git a/src/util/tests/createPRInfo.ts b/src/util/tests/createPRInfo.ts index d79a341..8db591e 100644 --- a/src/util/tests/createPRInfo.ts +++ b/src/util/tests/createPRInfo.ts @@ -4,7 +4,7 @@ export const createPRInfo = (info?: Partial): PRInfo => { return { comments: [], authorIsMemberOfTSTeam: false, - authorIsTypescriptBot: false, + authorIsBot: false, relatedIssues: [], thisIssue: { issue_number: 35454,