Move more rules to "not doing"

microsoft · Oct 30, 2017 · 79b9156 · 79b9156
1 parent 525a528
commit 79b9156
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/src/compiler/symbolWalker.ts b/src/compiler/symbolWalker.ts
@@ -122,7 +122,7 @@ namespace ts {
                 }
                 forEach(signature.typeParameters, visitType);
 
-                for (const parameter of signature.parameters){
+                for (const parameter of signature.parameters) {
                     visitSymbol(parameter);
                 }
                 visitType(getRestTypeOfSignature(signature));

diff --git a/tslint.json b/tslint.json
@@ -74,18 +74,18 @@
         // TODO
         "arrow-parens": false, // [true, "ban-single-arg-parens"]
         "arrow-return-shorthand": false,
+        "ban-comma-operator": false,
         "ban-types": false,
         "callable-types": false,
         "forin": false,
-        "interface-name": false, // [true, "never-prefix"],
         "member-access": false, // [true, "no-public"]
-        "no-angle-bracket-type-assertion": false,
         "no-conditional-assignment": false,
         "no-console": false,
         "no-debugger": false,
         "no-empty": false,
         "no-empty-interface": false,
         "no-eval": false,
+        "no-implicit-dependencies": false,
         "no-invalid-template-strings": false,
         "no-object-literal-type-assertion": false,
         "no-shadowed-variable": false,
@@ -95,7 +95,6 @@
         "no-unnecessary-initializer": false,
         "no-var-requires": false,
         "object-literal-key-quotes": false,
-        "one-variable-per-declaration": false,
         "only-arrow-functions": false,
         "ordered-imports": false,
         "prefer-conditional-expression": false,
@@ -106,18 +105,21 @@
         "unified-signatures": false,
         "variable-name": false,
 
-        // https://github.com/Microsoft/TypeScript/issues/18340
+        // These should be done automatically by a formatter. https://github.com/Microsoft/TypeScript/issues/18340
         "align": false,
         "eofline": false,
         "max-line-length": false,
         "no-consecutive-blank-lines": false,
 
         // Not doing
+        "interface-name": false,
         "max-classes-per-file": false,
         "member-ordering": false,
+        "no-angle-bracket-type-assertion": false,
         "no-bitwise": false,
         "no-namespace": false,
         "no-reference": false,
-        "object-literal-sort-keys": false
+        "object-literal-sort-keys": false,
+        "one-variable-per-declaration": false
 	}
 }