Promise.{all,race} static method's iterable definitions incorrectly omit other definitions by overloading (regression)

[falsandtru]

es2015.iterable.d.ts must not omit es2015.promise.d.ts definitions by overloading. However, npm package distributions work correctly.

TypeScript Version: 2.6.0 RC for Visual Studio 2015

Code

Promise.all([0, 0]);

Expected behavior:

Should use definitions of es2015.promise.d.ts.

Promise.all([0, 0]); // Promise<[number, number]>

Actual behavior:

Uses definitions of es2015.iterable.d.ts.

Promise.all([0, 0]); // Promise<number[]>

[weswigham]

I can't repro this. Is your TS version for that project set to 2.6?:

If it's still 2.3, you'll end up using the 2.3 lib, which has this bug.

[falsandtru]

I'm using only .csproj file: https://github.com/falsandtru/pjax-api/blob/master/pjax-api.csproj

[weswigham]

I don't seem to have an issue with your project using the 2.6 RC SDK:

[weswigham]

Oh, wait, you said VS 2015, and I've been looking at 2017. That's probably important. Well, at least I know this is minimally isolated to vs2015.

[weswigham]

Confirmed in vs2015 only:

The files are still ordered correctly in the library files, so I can only assume this is because the vs2015 extension is loading the TS library files in some other order than what is specified. Either that, or.... this is the only extension where we still use chakra, so we may be relying on object insertion ordering somewhere? Continuing to look into this.

[falsandtru]

Thanks for your investigation.