From 0323e261c241b000a87be740946193963d980a1c Mon Sep 17 00:00:00 2001 From: zhengbli Date: Thu, 3 Nov 2016 11:01:24 -0700 Subject: [PATCH 1/2] add test for the fix for overwrite emitting error --- .../unittests/tsserverProjectSystem.ts | 24 +++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/src/harness/unittests/tsserverProjectSystem.ts b/src/harness/unittests/tsserverProjectSystem.ts index 7f12036a77740..c24193db78f4d 100644 --- a/src/harness/unittests/tsserverProjectSystem.ts +++ b/src/harness/unittests/tsserverProjectSystem.ts @@ -2470,4 +2470,28 @@ namespace ts.projectSystem { }); }); + + describe("No overwrite emit error", () => { + it("for inferred project", () => { + const f1 = { + path: "/a/b/f1.js", + content: "function test1() { }" + }; + const host = createServerHost([f1, libFile]); + const session = createSession(host); + openFilesForSession([f1], session); + + const projectService = session.getProjectService(); + assert.isNotNull(projectService.inferredProjects[0]); + const projectName = projectService.inferredProjects[0].getProjectName(); + + const diags = session.executeCommand({ + type: "request", + command: server.CommandNames.CompilerOptionsDiagnosticsFull, + seq: 2, + arguments: { projectFileName: projectName } + }).response; + assert.isTrue(diags.length === 0); + }); + }); } \ No newline at end of file From bb16cceb04391cdb343d175894e8f752b02b1918 Mon Sep 17 00:00:00 2001 From: zhengbli Date: Thu, 3 Nov 2016 11:28:58 -0700 Subject: [PATCH 2/2] cr feedback --- src/harness/unittests/tsserverProjectSystem.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/harness/unittests/tsserverProjectSystem.ts b/src/harness/unittests/tsserverProjectSystem.ts index c24193db78f4d..12bb4daf0996e 100644 --- a/src/harness/unittests/tsserverProjectSystem.ts +++ b/src/harness/unittests/tsserverProjectSystem.ts @@ -2482,7 +2482,7 @@ namespace ts.projectSystem { openFilesForSession([f1], session); const projectService = session.getProjectService(); - assert.isNotNull(projectService.inferredProjects[0]); + checkNumberOfProjects(projectService, { inferredProjects: 1 }); const projectName = projectService.inferredProjects[0].getProjectName(); const diags = session.executeCommand({