From 54208793a29f8f20992abfbf2965dabb8c451746 Mon Sep 17 00:00:00 2001
From: Andy <anhans@microsoft.com>
Date: Tue, 7 Nov 2017 07:41:21 -0800
Subject: [PATCH] Fix assertion -- an import may come from a require() call
 (#19667)

* Fix assertion -- an import may come from a require() call

* Add test for `import("./a")`
---
 src/services/codefixes/importFixes.ts         |  6 ++-
 .../fourslash/completionsImport_require.ts    | 42 +++++++++++++++++++
 2 files changed, 46 insertions(+), 2 deletions(-)
 create mode 100644 tests/cases/fourslash/completionsImport_require.ts

diff --git a/src/services/codefixes/importFixes.ts b/src/services/codefixes/importFixes.ts
index 3f0d27e5b070f..1844f98cb37c1 100644
--- a/src/services/codefixes/importFixes.ts
+++ b/src/services/codefixes/importFixes.ts
@@ -237,10 +237,12 @@ namespace ts.codefix {
                 return parent as ImportDeclaration;
             case SyntaxKind.ExternalModuleReference:
                 return (parent as ExternalModuleReference).parent;
-            default:
-                Debug.assert(parent.kind === SyntaxKind.ExportDeclaration);
+            case SyntaxKind.ExportDeclaration:
+            case SyntaxKind.CallExpression: // For "require()" calls
                 // Ignore these, can't add imports to them.
                 return undefined;
+            default:
+                Debug.fail();
         }
     }
 
diff --git a/tests/cases/fourslash/completionsImport_require.ts b/tests/cases/fourslash/completionsImport_require.ts
new file mode 100644
index 0000000000000..e0a6b00d4622c
--- /dev/null
+++ b/tests/cases/fourslash/completionsImport_require.ts
@@ -0,0 +1,42 @@
+/// <reference path="fourslash.ts" />
+
+// @allowJs: true
+
+// @Filename: /a.ts
+////export const foo = 0;
+
+// @Filename: /b.js
+////const a = require("./a");
+////fo/*b*/
+
+// @Filename: /c.js
+////const a = import("./a");
+////fo/*c*/
+
+goTo.marker("b");
+verify.completionListContains({ name: "foo", source: "/a" }, "const foo: 0", "", "const", /*spanIndex*/ undefined, /*hasAction*/ true, { includeExternalModuleExports: true });
+
+verify.applyCodeActionFromCompletion("b", {
+    name: "foo",
+    source: "/a",
+    description: `Import 'foo' from "./a".`,
+    // TODO: GH#18445
+    newFileContent: `import { foo } from "./a";\r
+\r
+const a = require("./a");
+fo`,
+});
+
+goTo.marker("c");
+verify.completionListContains({ name: "foo", source: "/a" }, "const foo: 0", "", "const", /*spanIndex*/ undefined, /*hasAction*/ true, { includeExternalModuleExports: true });
+
+verify.applyCodeActionFromCompletion("c", {
+    name: "foo",
+    source: "/a",
+    description: `Import 'foo' from "./a".`,
+    // TODO: GH#18445
+    newFileContent: `import { foo } from "./a";\r
+\r
+const a = import("./a");
+fo`,
+});