Use empty object for invalid package json contents instead of undefined #34906
Conversation
There was a problem hiding this comment.
This changes the (intended) behavior of auto-imports when an invalid package.json is encountered—the intention was that auto-imports would not be filtered; with this change, no auto-imports from node_modules will be offered since the package.json appears to list no dependencies.
I think that’s probably ok since this is likely a transient state, but it would be a little better to pretend the package.json didn’t exist and not filter the auto-imports. Would it be difficult to fix the stack overflow but still return undefined here?
|
@andrewbranch changed as per your feedback |
|
@typescript-bot cherry-pick this to release-3.7 |
|
Hey @sheetalkamat, I've opened #35006 for you. |
Component commits: dfa4bc0 Use empty object for invalid package json contents instead of undefined Fixes microsoft#34726 4d035ba Behave as if package json doesnt exist in case of invalid json in package json
Fixes #34726