Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(39836): unknown type declaration for catch argument doesn't work in js #42392

Merged
merged 1 commit into from
Mar 5, 2021
Merged

fix(39836): unknown type declaration for catch argument doesn't work in js #42392

merged 1 commit into from
Mar 5, 2021

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #39836

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Jan 18, 2021
sandersn
sandersn requested changes Mar 4, 2021
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested a couple of changes

src/compiler/checker.ts Outdated Show resolved Hide resolved
tests/baselines/reference/api/tsserverlibrary.d.ts Show resolved Hide resolved
@sandersn sandersn self-assigned this Mar 4, 2021
@a-tarasyuk a-tarasyuk requested a review from sandersn March 4, 2021 18:53
@sandersn sandersn merged commit ca8d9e4 into microsoft:master Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser

Assignees

@sandersn sandersn

Labels
For Backlog Bug PRs that fix a backlog bug
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unknown type declaration for catch argument doesn't work in js
4 participants
@a-tarasyuk @sandersn @DanielRosenwasser @typescript-bot