-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly check whether union type contains only primitive types #46645
Conversation
I'd definitely recommend cherry picking this for 4.5.1, particularly since the issue is somewhat unpredictable. |
@typescript-bot cherry-pick this to release-4.5 |
Heya @andrewbranch, I've started to run the task to cherry-pick this into |
Just fixed the regression test. Will start a new cherry pick. |
@typescript-bot cherry-pick this to release-4.5 |
Heya @ahejlsberg, I've started to run the task to cherry-pick this into |
Hey @ahejlsberg, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.5 manually. |
@typescript-bot cherry-pick this to release-4.5 (#46647) |
Heya @andrewbranch, I've started to run the task to cherry-pick this into |
Hey @andrewbranch, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.5 manually. |
The cherry-pick build checks out the PR head, not the merge commit, so my change to the script didn't get picked up. We'll have to do this one manually. |
…osoft#46645) * Properly check whether union type contains only primitive types * Add regression test * Remove 'export' modifier from test
…) (#46649) * Properly check whether union type contains only primitive types * Add regression test * Remove 'export' modifier from test Co-authored-by: Anders Hejlsberg <andersh@microsoft.com>
…osoft#46645) * Properly check whether union type contains only primitive types * Add regression test * Remove 'export' modifier from test
Fixes #46624.