Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly check whether union type contains only primitive types #46645

Merged
merged 3 commits into from
Nov 2, 2021

Conversation

ahejlsberg
Copy link
Member

Fixes #46624.

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Nov 2, 2021
@ahejlsberg
Copy link
Member Author

I'd definitely recommend cherry picking this for 4.5.1, particularly since the issue is somewhat unpredictable.

@andrewbranch
Copy link
Member

@typescript-bot cherry-pick this to release-4.5

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 2, 2021

Heya @andrewbranch, I've started to run the task to cherry-pick this into release-4.5 on this PR at f9aa40e. You can monitor the build here.

@ahejlsberg
Copy link
Member Author

Just fixed the regression test. Will start a new cherry pick.

@ahejlsberg
Copy link
Member Author

@typescript-bot cherry-pick this to release-4.5

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 2, 2021

Heya @ahejlsberg, I've started to run the task to cherry-pick this into release-4.5 on this PR at 5010346. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

Hey @ahejlsberg, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.5 manually.

@andrewbranch
Copy link
Member

@typescript-bot cherry-pick this to release-4.5

(#46647)

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 2, 2021

Heya @andrewbranch, I've started to run the task to cherry-pick this into release-4.5 on this PR at 5010346. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

Hey @andrewbranch, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.5 manually.

@ahejlsberg ahejlsberg merged commit 56f8107 into main Nov 2, 2021
@ahejlsberg ahejlsberg deleted the fix46624 branch November 2, 2021 19:46
@andrewbranch
Copy link
Member

The cherry-pick build checks out the PR head, not the merge commit, so my change to the script didn't get picked up. We'll have to do this one manually.

andrewbranch pushed a commit to andrewbranch/TypeScript that referenced this pull request Nov 2, 2021
…osoft#46645)

* Properly check whether union type contains only primitive types

* Add regression test

* Remove 'export' modifier from test
DanielRosenwasser pushed a commit that referenced this pull request Nov 3, 2021
…) (#46649)

* Properly check whether union type contains only primitive types

* Add regression test

* Remove 'export' modifier from test

Co-authored-by: Anders Hejlsberg <andersh@microsoft.com>
mprobst pushed a commit to mprobst/TypeScript that referenced this pull request Jan 10, 2022
…osoft#46645)

* Properly check whether union type contains only primitive types

* Add regression test

* Remove 'export' modifier from test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

some types in 4.5.0 aren't correctly resolving to same types in 4.4.4
3 participants