From 02c075616abd99d56d564a918f10278647ced176 Mon Sep 17 00:00:00 2001
From: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
Date: Wed, 9 Nov 2022 14:41:26 -0800
Subject: [PATCH] Remove no-unnecessary-qualifier from eslintrc

---
 src/.eslintrc.json                           | 1 -
 src/server/protocol.ts                       | 2 --
 src/testRunner/unittests/tsserver/helpers.ts | 2 +-
 src/testRunner/unittests/tsserver/session.ts | 2 +-
 src/typingsInstallerCore/typingsInstaller.ts | 4 ----
 5 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/src/.eslintrc.json b/src/.eslintrc.json
index f29dc06406312..d4b49a9527805 100644
--- a/src/.eslintrc.json
+++ b/src/.eslintrc.json
@@ -5,7 +5,6 @@
         "project": "./tsconfig-base.json"
     },
     "rules": {
-        "@typescript-eslint/no-unnecessary-qualifier": "error",
         "@typescript-eslint/no-unnecessary-type-assertion": "error",
         "no-restricted-globals": ["error",
             { "name": "setTimeout" },
diff --git a/src/server/protocol.ts b/src/server/protocol.ts
index 7d0c25f951a29..6187031e040c2 100644
--- a/src/server/protocol.ts
+++ b/src/server/protocol.ts
@@ -5,8 +5,6 @@ import {
     TodoComment, TodoCommentDescriptor, TypeAcquisition,
 } from "./_namespaces/ts";
 
-/* eslint-disable @typescript-eslint/no-unnecessary-qualifier */
-
 /**
  * Declaration module describing the TypeScript Server protocol
  */
diff --git a/src/testRunner/unittests/tsserver/helpers.ts b/src/testRunner/unittests/tsserver/helpers.ts
index c5761dd4b9185..7371eed206d17 100644
--- a/src/testRunner/unittests/tsserver/helpers.ts
+++ b/src/testRunner/unittests/tsserver/helpers.ts
@@ -320,7 +320,7 @@ export class TestServerEventManager {
             configFileName: "tsconfig.json",
             projectType: "configured",
             languageServiceEnabled: true,
-            version: ts.version, // eslint-disable-line @typescript-eslint/no-unnecessary-qualifier
+            version: ts.version,
             ...partial,
         });
     }
diff --git a/src/testRunner/unittests/tsserver/session.ts b/src/testRunner/unittests/tsserver/session.ts
index fe6edf98a77bd..902933100ae22 100644
--- a/src/testRunner/unittests/tsserver/session.ts
+++ b/src/testRunner/unittests/tsserver/session.ts
@@ -186,7 +186,7 @@ describe("unittests:: tsserver:: Session:: General functionality", () => {
             };
 
             const expected: ts.server.protocol.StatusResponseBody = {
-                version: ts.version, // eslint-disable-line @typescript-eslint/no-unnecessary-qualifier
+                version: ts.version,
             };
             assert.deepEqual(session.executeCommand(req).response, expected);
         });
diff --git a/src/typingsInstallerCore/typingsInstaller.ts b/src/typingsInstallerCore/typingsInstaller.ts
index c40443366380c..ded0edd9250d6 100644
--- a/src/typingsInstallerCore/typingsInstaller.ts
+++ b/src/typingsInstallerCore/typingsInstaller.ts
@@ -350,8 +350,6 @@ export abstract class TypingsInstaller {
         this.sendResponse({
             kind: EventBeginInstallTypes,
             eventId: requestId,
-            // qualified explicitly to prevent occasional shadowing
-            // eslint-disable-next-line @typescript-eslint/no-unnecessary-qualifier
             typingsInstallerVersion: version,
             projectName: req.projectName
         } as BeginInstallTypes);
@@ -401,8 +399,6 @@ export abstract class TypingsInstaller {
                     projectName: req.projectName,
                     packagesToInstall: scopedTypings,
                     installSuccess: ok,
-                    // qualified explicitly to prevent occasional shadowing
-                    // eslint-disable-next-line @typescript-eslint/no-unnecessary-qualifier
                     typingsInstallerVersion: version
                 };
                 this.sendResponse(response);