Fixed a crash in getPropertyNameForPropertyNameNode on NoSubstitutionTemplateLiteral
#55930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ionTemplateLiteral`
Member
|
I'm not seeing the crash in the playground - what am I doing wrong? |
Contributor
Author
|
It’s a lazy crash - you need to hover over the resulting type to request this information |
Collaborator
|
Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page. Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up. |
Member
|
Okay, so function Foo() {}
Foo[`b`] = function () {};
type Test = keyof typeof Foo;
// ^? |
DanielRosenwasser
approved these changes
Oct 2, 2023
osyrisrblx
added a commit
to roblox-ts/roblox-ts
that referenced
this pull request
Feb 14, 2024
- Bumps `typescript` and `ts-expose-internals` to v5.3.3 - Removes the test diagnostic for `noSuperProperty` as the compiler catches this now (microsoft/TypeScript/pull/54056) - Make 1:1 changes for methods and fields - Handles the `NoSubstitutionTemplateLiteral` node from microsoft/TypeScript/pull/55930 Please take a look at the module resolution change. I'm not sure if this will have downstream effects that I couldn't catch in testing. Closes #2610 --------- Co-authored-by: Osyris <osyrisrblx@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.