From ee42d75fa2119be268794bfd7bf1fc4da8bab8b4 Mon Sep 17 00:00:00 2001
From: ahmed walid <ahmed.walid605@yahoo.com>
Date: Sat, 9 Sep 2023 03:20:41 +0200
Subject: [PATCH 1/2] Fix outdated remarks/attributes about Composition support
 for effects

---
 winrt/docsrc/CanvasDrawingSession.xml         | 14 +++++-----
 winrt/docsrc/effects/BlendEffect.xml          | 28 +++++++++++++------
 winrt/docsrc/effects/LinearTransferEffect.xml |  3 +-
 3 files changed, 29 insertions(+), 16 deletions(-)

diff --git a/winrt/docsrc/CanvasDrawingSession.xml b/winrt/docsrc/CanvasDrawingSession.xml
index ae60114d3..a96223d00 100644
--- a/winrt/docsrc/CanvasDrawingSession.xml
+++ b/winrt/docsrc/CanvasDrawingSession.xml
@@ -754,12 +754,12 @@ Licensed under the MIT License. See LICENSE.txt in the project root for license
     <member name="T:Microsoft.Graphics.Canvas.CanvasComposite">
       <summary>The composite mode used for the effect.</summary>
       <remarks>
-        <p>The equations listed in enum descriptions use these elements:
-           O = Output
-           S = Source
-           SA = Source Alpha
-           D = Destination
-           DA = Destination Alpha</p>
+        <p>The equations listed in enum descriptions use these elements:</p>
+        <p>O = Output</p>
+        <p>S = Source</p>
+        <p>SA = Source Alpha</p>
+        <p>D = Destination</p>
+        <p>DA = Destination Alpha</p>
       </remarks>
     </member>
     <member name="F:Microsoft.Graphics.Canvas.CanvasComposite.SourceOver">
@@ -796,7 +796,7 @@ Licensed under the MIT License. See LICENSE.txt in the project root for license
     <member name="F:Microsoft.Graphics.Canvas.CanvasComposite.Copy">
       <summary>Region of the source bitmap. Equation: O = S.</summary>
     </member>
-    <member name="F:Microsoft.Graphics.Canvas.CanvasComposite.BoundedCopy">
+    <member name="F:Microsoft.Graphics.Canvas.CanvasComposite.BoundedCopy" NoComposition="true">
       <summary>Union of source and destination bitmaps with no destination override. 
                Equation: O = S (only where source exists).</summary>
     </member>
diff --git a/winrt/docsrc/effects/BlendEffect.xml b/winrt/docsrc/effects/BlendEffect.xml
index d892f9c27..c162251bd 100644
--- a/winrt/docsrc/effects/BlendEffect.xml
+++ b/winrt/docsrc/effects/BlendEffect.xml
@@ -127,17 +127,29 @@ Licensed under the MIT License. See LICENSE.txt in the project root for license
     <member name="F:Microsoft.Graphics.Canvas.Effects.BlendEffectMode.Exclusion">
       <summary>Exclusion blend mode. <img src="../media/BlendEffectMode_Exclusion.png"/></summary>
     </member>
-    <member name="F:Microsoft.Graphics.Canvas.Effects.BlendEffectMode.Hue" NoComposition="true">
-      <summary>Hue blend mode. <img src="../media/BlendEffectMode_Hue.png"/></summary>
+    <member name="F:Microsoft.Graphics.Canvas.Effects.BlendEffectMode.Hue">
+      <summary>
+	    <p>Hue blend mode. <img src="../media/BlendEffectMode_Hue.png"/></p>
+        <p>This blend mode is supported by Windows.UI.Composition since Windows 10 build 18362 (May 2019 Update).</p>
+      </summary>
     </member>
-    <member name="F:Microsoft.Graphics.Canvas.Effects.BlendEffectMode.Saturation" NoComposition="true">
-      <summary>Saturation blend mode. <img src="../media/BlendEffectMode_Saturation.png"/></summary>
+    <member name="F:Microsoft.Graphics.Canvas.Effects.BlendEffectMode.Saturation">
+      <summary>
+	    <p>Saturation blend mode. <img src="../media/BlendEffectMode_Saturation.png"/></p>
+        <p>This blend mode is supported by Windows.UI.Composition since Windows 10 build 18362 (May 2019 Update).</p>
+      </summary>
     </member>
-    <member name="F:Microsoft.Graphics.Canvas.Effects.BlendEffectMode.Color" NoComposition="true">
-      <summary>Color blend mode. <img src="../media/BlendEffectMode_Color.png"/></summary>
+    <member name="F:Microsoft.Graphics.Canvas.Effects.BlendEffectMode.Color">
+      <summary>
+	    <p>Color blend mode. <img src="../media/BlendEffectMode_Color.png"/></p>
+        <p>This blend mode is supported by Windows.UI.Composition since Windows 10 build 18362 (May 2019 Update).</p>
+      </summary>
     </member>
-    <member name="F:Microsoft.Graphics.Canvas.Effects.BlendEffectMode.Luminosity" NoComposition="true">
-      <summary>Luminosity blend mode. <img src="../media/BlendEffectMode_Luminosity.png"/></summary>
+    <member name="F:Microsoft.Graphics.Canvas.Effects.BlendEffectMode.Luminosity">
+      <summary>
+	    <p>Luminosity blend mode. <img src="../media/BlendEffectMode_Luminosity.png"/></p>
+        <p>This blend mode is supported by Windows.UI.Composition since Windows 10 build 18362 (May 2019 Update).</p>
+      </summary>
     </member>
     <member name="F:Microsoft.Graphics.Canvas.Effects.BlendEffectMode.Subtract">
       <summary>Subtract blend mode. <img src="../media/BlendEffectMode_Subtract.png"/></summary>
diff --git a/winrt/docsrc/effects/LinearTransferEffect.xml b/winrt/docsrc/effects/LinearTransferEffect.xml
index 25fe75a38..2d93b7bf9 100644
--- a/winrt/docsrc/effects/LinearTransferEffect.xml
+++ b/winrt/docsrc/effects/LinearTransferEffect.xml
@@ -11,11 +11,12 @@ Licensed under the MIT License. See LICENSE.txt in the project root for license
   </assembly>
   <members>
   
-    <member name="T:Microsoft.Graphics.Canvas.Effects.LinearTransferEffect" NoComposition="true">
+    <member name="T:Microsoft.Graphics.Canvas.Effects.LinearTransferEffect">
       <summary>
         Alters the colors of an image by applying a per-channel linear transfer function.
       </summary>
       <remarks>
+        <p>This effect is supported by Windows.UI.Composition since Windows 10 build 14393 (Anniversary Update).</p>
         <p>The linear transfer function is evaluated separately for each color channel:</p>
         <p>result = (input * slope) + offset</p>
         <p>

From ac2dda2281c791d13687991ed0aa8145cd7f4120 Mon Sep 17 00:00:00 2001
From: ahmed walid <ahmed.walid605@yahoo.com>
Date: Sat, 9 Sep 2023 15:58:18 +0200
Subject: [PATCH 2/2] Use list for CanvasComposite elements remark

---
 winrt/docsrc/CanvasDrawingSession.xml | 12 +++++++-----
 winrt/docsrc/effects/BlendEffect.xml  |  8 ++++----
 2 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/winrt/docsrc/CanvasDrawingSession.xml b/winrt/docsrc/CanvasDrawingSession.xml
index a96223d00..2792ee410 100644
--- a/winrt/docsrc/CanvasDrawingSession.xml
+++ b/winrt/docsrc/CanvasDrawingSession.xml
@@ -755,11 +755,13 @@ Licensed under the MIT License. See LICENSE.txt in the project root for license
       <summary>The composite mode used for the effect.</summary>
       <remarks>
         <p>The equations listed in enum descriptions use these elements:</p>
-        <p>O = Output</p>
-        <p>S = Source</p>
-        <p>SA = Source Alpha</p>
-        <p>D = Destination</p>
-        <p>DA = Destination Alpha</p>
+        <ul>
+          <li>O = Output</li>
+          <li>S = Source</li>
+          <li>SA = Source Alpha</li>
+          <li>D = Destination</li>
+          <li>DA = Destination Alpha</li>
+        </ul>
       </remarks>
     </member>
     <member name="F:Microsoft.Graphics.Canvas.CanvasComposite.SourceOver">
diff --git a/winrt/docsrc/effects/BlendEffect.xml b/winrt/docsrc/effects/BlendEffect.xml
index c162251bd..bccd59aa6 100644
--- a/winrt/docsrc/effects/BlendEffect.xml
+++ b/winrt/docsrc/effects/BlendEffect.xml
@@ -129,25 +129,25 @@ Licensed under the MIT License. See LICENSE.txt in the project root for license
     </member>
     <member name="F:Microsoft.Graphics.Canvas.Effects.BlendEffectMode.Hue">
       <summary>
-	    <p>Hue blend mode. <img src="../media/BlendEffectMode_Hue.png"/></p>
+        <p>Hue blend mode. <img src="../media/BlendEffectMode_Hue.png"/></p>
         <p>This blend mode is supported by Windows.UI.Composition since Windows 10 build 18362 (May 2019 Update).</p>
       </summary>
     </member>
     <member name="F:Microsoft.Graphics.Canvas.Effects.BlendEffectMode.Saturation">
       <summary>
-	    <p>Saturation blend mode. <img src="../media/BlendEffectMode_Saturation.png"/></p>
+        <p>Saturation blend mode. <img src="../media/BlendEffectMode_Saturation.png"/></p>
         <p>This blend mode is supported by Windows.UI.Composition since Windows 10 build 18362 (May 2019 Update).</p>
       </summary>
     </member>
     <member name="F:Microsoft.Graphics.Canvas.Effects.BlendEffectMode.Color">
       <summary>
-	    <p>Color blend mode. <img src="../media/BlendEffectMode_Color.png"/></p>
+        <p>Color blend mode. <img src="../media/BlendEffectMode_Color.png"/></p>
         <p>This blend mode is supported by Windows.UI.Composition since Windows 10 build 18362 (May 2019 Update).</p>
       </summary>
     </member>
     <member name="F:Microsoft.Graphics.Canvas.Effects.BlendEffectMode.Luminosity">
       <summary>
-	    <p>Luminosity blend mode. <img src="../media/BlendEffectMode_Luminosity.png"/></p>
+        <p>Luminosity blend mode. <img src="../media/BlendEffectMode_Luminosity.png"/></p>
         <p>This blend mode is supported by Windows.UI.Composition since Windows 10 build 18362 (May 2019 Update).</p>
       </summary>
     </member>