Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CentralPackageManagement on Certain Projects MrtCoreManagedTest.csproj and Microsoft.FrameworkUdk.PackageReference.cspro #4585

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Directory.Packages.props
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,11 @@
<PackageVersion Include="System.Net.Http" Version="4.3.4" />
<PackageVersion Include="System.Text.Json" Version="8.0.4" />
<PackageVersion Include="Microsoft.VSSDK.BuildTools" Version="17.4.2118" />
<PackageVersion Include="Microsoft.NETCore.UniversalWindowsPlatform" Version="6.2.10" />
<PackageVersion Include="Microsoft.WindowsAppSDK" Version="$(WindowsAppSDKVersion)" Condition=" '$(WindowsAppSDKVersion)' != '' " />
<PackageVersion Include="Microsoft.Windows.CppWinRT" Version="$(CppWinRTVersion)" Condition=" '$(CppWinRTVersion)' != '' " />
<PackageVersion Include="Microsoft.Windows.SDK.BuildTools" Version="$(WindowsSDKBuildToolsVersion)" Condition=" '$(WindowsSDKBuildToolsVersion)' != '' " />
<PackageVersion Include="Microsoft.Windows.ImplementationLibrary" Version="$(WILVersion)" Condition=" '$(WILVersion)' != '' " />
<PackageVersion Include="Microsoft.FrameworkUdk" version="[$(MicrosoftFrameworkUdkPackageVersion)]" Condition=" '$(MicrosoftFrameworkUdkPackageVersion)' != '' " />
</ItemGroup>
</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,6 @@
<AppxPackageSigningEnabled>false</AppxPackageSigningEnabled>
</PropertyGroup>

<PropertyGroup>
<!-- Getting errors. Disable for now -->
<ManagePackageVersionsCentrally>false</ManagePackageVersionsCentrally>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Debug|x86'">
<DebugSymbols>true</DebugSymbols>
<DefineConstants>NETFX_CORE;WINDOWS_UWP;CODE_ANALYSIS</DefineConstants>
Expand Down Expand Up @@ -152,12 +147,8 @@
<Content Include="Assets\Wide310x150Logo.scale-200.png" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="Microsoft.NETCore.UniversalWindowsPlatform">
<Version>6.2.10</Version>
</PackageReference>
<PackageReference Include="Newtonsoft.Json">
<Version>13.0.2</Version>
</PackageReference>
<PackageReference Include="Microsoft.NETCore.UniversalWindowsPlatform" />
<PackageReference Include="Newtonsoft.Json" />
</ItemGroup>
<!-- For some reason, TAEF binplaces the wrong version of Wex.Logger.Interop.dll - we need to fix that.
Removing the version from the binaries directory to allow us to use the version from the lib directory is sufficient here.-->
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,9 @@
<AssemblyTitle>Microsoft.FrameworkUdk.PackageReference</AssemblyTitle>
</PropertyGroup>

<PropertyGroup>
<!-- Getting obj reference error. Disable for now (incompatible with PackageDownload??) -->
<ManagePackageVersionsCentrally>false</ManagePackageVersionsCentrally>
</PropertyGroup>

<ItemGroup>
<PackageDownload Include="Microsoft.FrameworkUdk" version="[$(MicrosoftFrameworkUdkPackageVersion)]" />
<PackageReference Include="Microsoft.FrameworkUdk">
<ExcludeAssets>all</ExcludeAssets>
</PackageReference>
</ItemGroup>
</Project>