Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Spec for Badge Notifications in WindowsAppSdk #4823

Merged
merged 10 commits into from
Dec 12, 2024

Conversation

SatwikKrSharma
Copy link
Contributor

This is the API Spec for the Badge Notifications in WindowsAppSdk. Issue - #138

A microsoft employee must use /azp run to validate using the pipelines below.

WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.

For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.

@anupriya13 anupriya13 requested a review from satkh October 23, 2024 14:27
@anupriya13 anupriya13 added api-design Updates to Project Reunion API surfaces area-Notifications Toast notification, badges, Live Tiles, push notifications labels Oct 23, 2024
@anupriya13 anupriya13 added this to the 1.7 milestone Oct 23, 2024
specs/BadgeNotifications/BadgeNotifications-spec.md Outdated Show resolved Hide resolved
specs/BadgeNotifications/BadgeNotifications-spec.md Outdated Show resolved Hide resolved
specs/BadgeNotifications/BadgeNotifications-spec.md Outdated Show resolved Hide resolved
specs/BadgeNotifications/BadgeNotifications-spec.md Outdated Show resolved Hide resolved
specs/BadgeNotifications/BadgeNotifications-spec.md Outdated Show resolved Hide resolved
specs/BadgeNotifications/BadgeNotifications-spec.md Outdated Show resolved Hide resolved
specs/BadgeNotifications/BadgeNotifications-spec.md Outdated Show resolved Hide resolved
specs/BadgeNotifications/BadgeNotifications-spec.md Outdated Show resolved Hide resolved
Copy link
Member

@jonwis jonwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks. Next up is API review with the reps group. I'll get something on the calendar for us. You are welcome to make a child branch now and start implementation if you'd like, just be aware that there may be interface-changing feedback.

@SatwikKrSharma SatwikKrSharma self-assigned this Nov 4, 2024
specs/BadgeNotifications/BadgeNotifications-spec.md Outdated Show resolved Hide resolved
specs/BadgeNotifications/BadgeNotifications-spec.md Outdated Show resolved Hide resolved
specs/BadgeNotifications/BadgeNotifications-spec.md Outdated Show resolved Hide resolved
specs/BadgeNotifications/BadgeNotifications-spec.md Outdated Show resolved Hide resolved
specs/BadgeNotifications/BadgeNotifications-spec.md Outdated Show resolved Hide resolved
specs/BadgeNotifications/BadgeNotifications-spec.md Outdated Show resolved Hide resolved
specs/BadgeNotifications/BadgeNotifications-spec.md Outdated Show resolved Hide resolved
specs/BadgeNotifications/BadgeNotifications-spec.md Outdated Show resolved Hide resolved
specs/BadgeNotifications/BadgeNotifications-spec.md Outdated Show resolved Hide resolved
specs/BadgeNotifications/BadgeNotifications-spec.md Outdated Show resolved Hide resolved
specs/BadgeNotifications/BadgeNotifications-spec.md Outdated Show resolved Hide resolved
specs/BadgeNotifications/BadgeNotifications-spec.md Outdated Show resolved Hide resolved
specs/BadgeNotifications/BadgeNotifications-spec.md Outdated Show resolved Hide resolved
specs/BadgeNotifications/BadgeNotifications-spec.md Outdated Show resolved Hide resolved
specs/BadgeNotifications/BadgeNotifications-spec.md Outdated Show resolved Hide resolved
specs/BadgeNotifications/BadgeNotifications-spec.md Outdated Show resolved Hide resolved
specs/BadgeNotifications/BadgeNotifications-spec.md Outdated Show resolved Hide resolved
specs/BadgeNotifications/BadgeNotifications-spec.md Outdated Show resolved Hide resolved
@SatwikKrSharma
Copy link
Contributor Author

SatwikKrSharma commented Nov 27, 2024 via email

@SatwikKrSharma SatwikKrSharma force-pushed the user/satwiksharma/badgeNotificationApiSpec branch from b24d8dd to 19abc54 Compare November 28, 2024 10:21
@SatwikKrSharma SatwikKrSharma requested review from vivekkhare31, oldnewthing and FrankC-msft and removed request for oldnewthing and FrankC-msft November 28, 2024 11:00
Copy link
Member

@jonwis jonwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes applied from API review. Thanks folks!

@Saharsh979
Copy link
Contributor

/azp run

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@SatwikKrSharma SatwikKrSharma merged commit 54743d7 into main Dec 12, 2024
2 checks passed
@SatwikKrSharma SatwikKrSharma deleted the user/satwiksharma/badgeNotificationApiSpec branch December 12, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-design Updates to Project Reunion API surfaces area-Notifications Toast notification, badges, Live Tiles, push notifications needs-triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants