Using jest projects config to run tests #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devaradhanm
changed the title
Shobhit1
reviewed
Jan 28, 2019
Shobhit1
reviewed
Jan 28, 2019
devaradhanm
force-pushed
the
users/devaradhanm/test
branch
from
19d99b4
to
7e2d7ca
Compare
|
The longer I consider the package-lock.json trickery to workaround that jest issue, the less comfortable I am with it - it's just too easy for someone to accidentally revert the workaround. Can you link the Jest issue in question? If we think they're likely to fix it soonish in a patch release, I kind of lean towards waiting for that before merging this. |
devaradhanm
force-pushed
the
users/devaradhanm/test
branch
from
7e2d7ca
to
e9fb864
Compare
jestjs/jest#6865 updating deprecated property remove tsconfig.jest.json ignore d.ts files form coverage This reverts commit 7875345cadaee70b4f2cb2c2d5d3d8554fe0354f.
devaradhanm
force-pushed
the
users/devaradhanm/test
branch
from
e9fb864
to
685153e
Compare
devaradhanm
commented
Feb 6, 2019
| @@ -51,7 +51,7 @@ async function verifyExtensionIsBuilt(extensionPath: string): Promise<void> { | |||
|
|
|||
| async function launchNewBrowser(): Promise<Puppeteer.Browser> { | |||
| // only unpacked extension paths are supported | |||
| const extensionPath = `${process.cwd()}/drop/dev/extension/`; | |||
| const extensionPath = `${(global as any).rootDir}/drop/dev/extension/`; | |||
There was a problem hiding this comment.
i had to make this change to support running "jest" from any directory
devaradhanm
commented
Feb 6, 2019
| }); | ||
|
|
||
| function verifySnapshot(props: ReportCheckListProps): void { | ||
| expect(shallow(<ReportCheckList {...props} />).getElement()).toMatchSnapshot(); |
There was a problem hiding this comment.
after jest update, shallow matching snapshot, doesnt output anything. So, i had to use getElement
dbjorge
reviewed
Feb 6, 2019
dbjorge
reviewed
Feb 6, 2019
dbjorge
reviewed
Feb 6, 2019
dbjorge
suggested changes
Feb 6, 2019
devaradhanm
force-pushed
the
users/devaradhanm/test
branch
from
2c3dcc7
to
93559d9
Compare
devaradhanm
force-pushed
the
users/devaradhanm/test
branch
from
93559d9
to
e376a4f
Compare
dbjorge
approved these changes
Feb 6, 2019
peterdur
approved these changes
Feb 6, 2019
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.