Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some SSLException variants can be transient and should be retried #270

Closed
guperrot opened this issue Dec 5, 2016 · 11 comments
Closed

Some SSLException variants can be transient and should be retried #270

guperrot opened this issue Dec 5, 2016 · 11 comments
Assignees

Comments

@guperrot
Copy link
Member

guperrot commented Dec 5, 2016

download

This exception should be retried as part of the existing http retry logic.

@Khoosham
Copy link

Khoosham commented Dec 5, 2016

thanks for opening the issue i sent you hope it gets resolve soon :)

@guperrot guperrot self-assigned this Dec 9, 2016
guperrot added a commit that referenced this issue Dec 9, 2016
guperrot added a commit that referenced this issue Dec 9, 2016
@guperrot
Copy link
Member Author

guperrot commented Dec 9, 2016

Will be part of 0.3.3 release.

@guperrot
Copy link
Member Author

guperrot commented Dec 9, 2016

@Khoosham can you test the fix by using this repository in your gradle config:

repositories {
    maven {
        url  "http://dl.bintray.com/mobile-center/mobile-center-snapshot" 
    }
}

Then specify version 0.3.3-9+80c98c4

@Khoosham
Copy link

Khoosham commented Dec 9, 2016

i tried the fix its not showing the error anymore. maybe i could not reproduce it or the fix is working.
will let u know if ever i get it again.

EDIT got it again
http://prntscr.com/dhgij1
http://prntscr.com/dhgjdw

@guperrot
Copy link
Member Author

guperrot commented Dec 9, 2016

@Khoosham Hi, the fix is working as the error is now retried. We cannot prevent transient errors from happening but the fix is to retry those.

Can you check that logs gets eventually sent after retrying? (The log tells you when the next try occurs).

@Khoosham
Copy link

Khoosham commented Dec 10, 2016

did it fail to send ?
i got this
http://prntscr.com/dhqnmi

edit:
http://prntscr.com/dhqr9k

@guperrot
Copy link
Member Author

If it's a warning, it is retried, if it's an error, we abort.
I need to add this new error to the list of what we can retry as its considered a fatal error now.
Again, it seems like a temporary issue when connection is unstable, so even after the fix you will see a warning instead of an error and then a retry later.

@guperrot guperrot changed the title SSLException with timeout is not retried Some SSLException variants can be transient and should be retried Dec 12, 2016
@guperrot
Copy link
Member Author

guperrot commented Dec 13, 2016

Hi @Khoosham , I added one more retry scenario for the last exception you mentioned in this thread.

Can you:

  • Verify the behavior on version 0.3.3-16+a060ba5.
  • Call MobileCenter.setLogLevel(Log.VERBOSE); and check it gets eventually retried (successful HTTP logs will be only displayed in verbose).
  • You can also check "Log flow" under "Analytics" on portal to see incoming individual logs (after the retry).

Thanks in advance.

@guperrot
Copy link
Member Author

You can actually test on official version 0.3.3 now, we released some fixes.

@Khoosham
Copy link

i think its working now response 200ok

Try #1 failed and will be retried in 6316 ms
java.io.EOFException at libcore.io.Streams.readAsciiLine(Streams.java:203)
at libcore.net.http.HttpEngine.readResponseHeaders(HttpEngine.java:579)
atlibcore.net.http.HttpEngine.readResponse(HttpEngine.java:827)................

http://prntscr.com/djmrpl

@guperrot
Copy link
Member Author

EOFException is already retried indeed.
Will close issue now, thanks for using Mobile Center.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants