Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sdk name on catalyst #2089

Closed

Conversation

annakocheshkova
Copy link

Things to consider before you submit the PR:

  • Has CHANGELOG.md been updated?
  • Are tests passing locally?
  • Are the files formatted correctly?
  • Did you add unit tests?
  • Did you check UI tests on the sample app? They are not executed on CI.
  • Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?

Description

We had appcenter.ios reported with xcframeworks and appcenter.macos reported through SPM package.
The name of the sdk should be one for each case. As discussed offline, this should most likely be "ios" since the sdk being used in "ios".

@annakocheshkova annakocheshkova mentioned this pull request May 29, 2020
5 tasks
@codecov-commenter
Copy link

codecov-commenter commented May 29, 2020

Codecov Report

Merging #2089 into feature/support-catalyst will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@                     Coverage Diff                      @@
##           feature/support-catalyst    #2089      +/-   ##
============================================================
- Coverage                     91.52%   91.40%   -0.12%     
============================================================
  Files                           129      129              
  Lines                         10133    10133              
============================================================
- Hits                           9274     9262      -12     
- Misses                          859      871      +12     
Flag Coverage Δ
#MacCatalyst 60.85% <ø> (-30.54%) ⬇️
#iOS 91.81% <ø> (ø)
#macOS 91.46% <ø> (ø)
#tvOS 90.91% <ø> (ø)
Impacted Files Coverage Δ
AppCenter/AppCenter/Internals/Util/MSUtility.m 56.00% <ø> (ø)
...pCenter/Internals/Context/Device/MSDeviceTracker.m 87.45% <0.00%> (-4.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e54e750...a0cb767. Read the comment docs.

Package.swift Outdated Show resolved Hide resolved
Config/iOS.xcconfig Outdated Show resolved Hide resolved
Anna Kocheshkova added 2 commits June 1, 2020 11:27
@MatkovIvan MatkovIvan closed this Jun 1, 2020
@MatkovIvan MatkovIvan deleted the fix/sdk-name-catalyst branch June 1, 2020 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants