From 89a88630f2c8ea19822075072fe582e5b994a058 Mon Sep 17 00:00:00 2001 From: Jesse Katsumata Date: Fri, 24 Jun 2022 15:02:35 +0900 Subject: [PATCH 1/3] fix: pod install for react-native/cli v8 --- appcenter-analytics/{ios => }/appcenter-analytics.podspec | 4 ++-- appcenter-analytics/react-native.config.js | 4 +--- appcenter-crashes/{ios => }/appcenter-crashes.podspec | 4 ++-- appcenter-crashes/react-native.config.js | 4 +--- appcenter/{ios => }/appcenter-core.podspec | 4 ++-- appcenter/react-native.config.js | 4 +--- 6 files changed, 9 insertions(+), 15 deletions(-) rename appcenter-analytics/{ios => }/appcenter-analytics.podspec (85%) rename appcenter-crashes/{ios => }/appcenter-crashes.podspec (85%) rename appcenter/{ios => }/appcenter-core.podspec (88%) diff --git a/appcenter-analytics/ios/appcenter-analytics.podspec b/appcenter-analytics/appcenter-analytics.podspec similarity index 85% rename from appcenter-analytics/ios/appcenter-analytics.podspec rename to appcenter-analytics/appcenter-analytics.podspec index ec4ef5f59b..0237379536 100644 --- a/appcenter-analytics/ios/appcenter-analytics.podspec +++ b/appcenter-analytics/appcenter-analytics.podspec @@ -1,6 +1,6 @@ require 'json' -package = JSON.parse(File.read(File.join(__dir__, '../package.json'))) +package = JSON.parse(File.read(File.join(__dir__, './package.json'))) Pod::Spec.new do |s| s.name = package['name'] @@ -12,7 +12,7 @@ Pod::Spec.new do |s| s.author = { 'Microsoft' => 'appcentersdk@microsoft.com' } s.source = { :git => "https://github.com/microsoft/appcenter-sdk-react-native.git" } - s.source_files = "AppCenterReactNativeAnalytics/**/*.{h,m}" + s.source_files = "ios/AppCenterReactNativeAnalytics/**/*.{h,m}" s.platform = :ios, '9.0' s.requires_arc = true diff --git a/appcenter-analytics/react-native.config.js b/appcenter-analytics/react-native.config.js index decc243542..85cb5a9ec0 100644 --- a/appcenter-analytics/react-native.config.js +++ b/appcenter-analytics/react-native.config.js @@ -3,9 +3,7 @@ const path = require('path'); module.exports = { dependency: { platforms: { - ios: { - podspecPath: path.join(__dirname, 'ios', 'appcenter-analytics.podspec') - }, + ios: {}, android: { packageInstance: 'new AppCenterReactNativeAnalyticsPackage(getApplication(), getResources().getString(R.string.appCenterAnalytics_whenToEnableAnalytics))' } diff --git a/appcenter-crashes/ios/appcenter-crashes.podspec b/appcenter-crashes/appcenter-crashes.podspec similarity index 85% rename from appcenter-crashes/ios/appcenter-crashes.podspec rename to appcenter-crashes/appcenter-crashes.podspec index fa37116dac..9cde8ed324 100644 --- a/appcenter-crashes/ios/appcenter-crashes.podspec +++ b/appcenter-crashes/appcenter-crashes.podspec @@ -1,6 +1,6 @@ require 'json' -package = JSON.parse(File.read(File.join(__dir__, '../package.json'))) +package = JSON.parse(File.read(File.join(__dir__, './package.json'))) Pod::Spec.new do |s| s.name = package['name'] @@ -13,7 +13,7 @@ Pod::Spec.new do |s| s.author = { 'Microsoft' => 'appcentersdk@microsoft.com' } s.source = { :git => "https://github.com/microsoft/appcenter-sdk-react-native.git" } - s.source_files = "AppCenterReactNativeCrashes/**/*.{h,m}" + s.source_files = "ios/AppCenterReactNativeCrashes/**/*.{h,m}" s.platform = :ios, '9.0' s.requires_arc = true diff --git a/appcenter-crashes/react-native.config.js b/appcenter-crashes/react-native.config.js index 6b9b1de5ba..e93e9a82e2 100644 --- a/appcenter-crashes/react-native.config.js +++ b/appcenter-crashes/react-native.config.js @@ -3,9 +3,7 @@ const path = require('path'); module.exports = { dependency: { platforms: { - ios: { - podspecPath: path.join(__dirname, 'ios', 'appcenter-crashes.podspec') - }, + ios: {}, android: { packageInstance: 'new AppCenterReactNativeCrashesPackage(getApplication(), getResources().getString(R.string.appCenterCrashes_whenToSendCrashes))' } diff --git a/appcenter/ios/appcenter-core.podspec b/appcenter/appcenter-core.podspec similarity index 88% rename from appcenter/ios/appcenter-core.podspec rename to appcenter/appcenter-core.podspec index a3ce4d9eda..e44aef3d6c 100644 --- a/appcenter/ios/appcenter-core.podspec +++ b/appcenter/appcenter-core.podspec @@ -1,6 +1,6 @@ require 'json' -package = JSON.parse(File.read(File.join(__dir__, '../package.json'))) +package = JSON.parse(File.read(File.join(__dir__, './package.json'))) Pod::Spec.new do |s| # The name is hardcoded due to a name conflict, resulting in the error 'Errno::ENOENT - No such file or directory @ rb_sysopen - appcenter.podspec.json' error. @@ -15,7 +15,7 @@ Pod::Spec.new do |s| s.author = { 'Microsoft' => 'appcentersdk@microsoft.com' } s.source = { :git => "https://github.com/microsoft/appcenter-sdk-react-native.git" } - s.source_files = "AppCenterReactNative/**/*.{h,m}" + s.source_files = "ios/AppCenterReactNative/**/*.{h,m}" s.platform = :ios, '9.0' s.requires_arc = true diff --git a/appcenter/react-native.config.js b/appcenter/react-native.config.js index 9d40c82a92..1b478c6221 100644 --- a/appcenter/react-native.config.js +++ b/appcenter/react-native.config.js @@ -3,9 +3,7 @@ const path = require('path'); module.exports = { dependency: { platforms: { - ios: { - podspecPath: path.join(__dirname, 'ios', 'appcenter-core.podspec') - }, + ios: {}, android: { packageInstance: 'new AppCenterReactNativePackage(getApplication())' } From 6d5eefd8e6e00e4589d7f70dcaae10a9e3b97f1c Mon Sep 17 00:00:00 2001 From: Dmitriy Kirakosyan Date: Thu, 30 Jun 2022 14:03:05 +0700 Subject: [PATCH 2/3] Fix eslint --- appcenter-analytics/react-native.config.js | 2 -- appcenter-crashes/react-native.config.js | 2 -- appcenter/react-native.config.js | 2 -- 3 files changed, 6 deletions(-) diff --git a/appcenter-analytics/react-native.config.js b/appcenter-analytics/react-native.config.js index 85cb5a9ec0..7e346cb93c 100644 --- a/appcenter-analytics/react-native.config.js +++ b/appcenter-analytics/react-native.config.js @@ -1,5 +1,3 @@ -const path = require('path'); - module.exports = { dependency: { platforms: { diff --git a/appcenter-crashes/react-native.config.js b/appcenter-crashes/react-native.config.js index e93e9a82e2..1da90b5706 100644 --- a/appcenter-crashes/react-native.config.js +++ b/appcenter-crashes/react-native.config.js @@ -1,5 +1,3 @@ -const path = require('path'); - module.exports = { dependency: { platforms: { diff --git a/appcenter/react-native.config.js b/appcenter/react-native.config.js index 1b478c6221..05cf02192b 100644 --- a/appcenter/react-native.config.js +++ b/appcenter/react-native.config.js @@ -1,5 +1,3 @@ -const path = require('path'); - module.exports = { dependency: { platforms: { From af5387bb784a22bb51d812378479711467e1788b Mon Sep 17 00:00:00 2001 From: Dmitriy Kirakosyan Date: Tue, 5 Jul 2022 14:00:42 +0700 Subject: [PATCH 3/3] Update CHANGELOG --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 342410cfa3..f89bc11217 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,10 @@ ## Version 4.4.5 (Under development) +### App Center + +* **[Fix]** Fix Autolinking for React Native 0.69. + ___ ## Version 4.4.4