-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] React Native stack trace does not show JS lines #248
Comments
The first crash is not Javascript. Something wrong happened in Facebook native code and their native module threw an objective C exception, not javascript. Our SDK also handles objective C exceptions and they look different. |
Thanks for replying. Is there anything that I can do to figure out the problem? |
This is all the information we got, you can probably get the RAW tab details of an individual occurrence and create a bug against React Native repository as they are probably causing the issue. |
Hey! We haven't heard from you in a while, so I am going to go ahead and close this conversation. Should you still have any questions, please don't hesitate to contact us again. Thanks for using App Center! |
@guperrot I have the same issue. i do:
And I only see the Objective-C trace. Showing RCTAssert.m line 132. I also specified send Javascript crashes at react-native link |
@mmiani @mattslight the SDK does not do anything special regarding symbolication, it all happens on server side with uploaded symbols that contain the source map. If you already made sure you uploaded symbols containing the javascript source map as documented in https://docs.microsoft.com/en-us/appcenter/diagnostics/symbolication#uploading-symbols and it's not working for you, then please open a support ticket from any page of https://appcenter.ms and describe the problem, preferably download the json report file from a single occurrence of the crash and share it with support engineers there. Also shouldProcess is a function that returns a boolean, not a just a boolean. |
Somehow our app ended up in this state as well. I believe it happened after updating to RN 59.10 |
Same issue, can't see what is the real problem here. |
@sarmad1995 I don't think it should. Have you managed to try the suggestions above? |
Same problem. I think this feature is down for new version of react native. |
@caisd1998 have you uploaded index.ios.map file in the same .zip file according to this paragraph? |
@russelarms There is no need to upload source map or symbol files, because I'm building within appcenter, it has been taken care of, see the top part of the document you mentioned:
|
This is the source code. |
Anyone found a solution?? I'm facing the same issue. I'm using appcenter to build and deploy the app |
There's nothing we can do. I've contacted with App Center support, and he confirmed this issue, just that is tracked as an internal bug, don't know when this can be fixed... |
I spent a bit of time on this recently as it is affecting my team as well. The most interesting and perhaps useful piece of information was that crashes inside the render loop seem to get their JS stack trace uploaded successfully. Crashes in response to e.g. an event handler callback (outside the render loop) do create a JS stack trace in the .plcrash file, which is textually subtly different than the render loop crash, but the JS portion of the crash dump (appended to "additional info") doesn't show up after it is uploaded. I haven't been able to figure out why; inspecting the structure of the exception that gets thrown by each of these cases doesn't show any discernable difference, and for obvious reasons it's really hard to debug the actual crash dump part of the process. |
Should also probably mention microsoft/appcenter#857 might be related. |
Here is the response from app center support: Minor update here: the work item is being reviewed and finalized. |
Did these commits helped anyone? I'm still not able to get JS lines in stacktrace. |
@victorkvarghese The fix isn't released yet, it will be included to the next version |
Hi,
We are working on figuring out why stack trace is not working for js for
over 2 months now..when can we expect a release ?
|
Before the end of this month, most likely in the next couple of days. |
Is this iOS specific? I'm experiencing the same issue on React Native Android. |
@patman1, unfortunately, we don't have support for JS stack traces on Android yet. |
This unbelievable feature gap deserves at least mention in official setup docs |
The new version of the SDK has been released with a fix: 3.0.0. |
This is the related changelog entry in core module that was responsible for this bug (it was not a bug in crashes module itself):
|
@victorkvarghese can that be reproduced on new, fresh project, or is it only after update? |
@Jamminroot i was having these issue on old version and the latest ones as well |
@victorkvarghese ok, and can it be reproduced on clean project? When you just create new project, add SDK, and try running few pieces of code? Or does it only occur after update to newer version? |
Also, have you, by any chance, ran |
@Jamminroot I diged deep to crash reports the But not sure why sdkversions are still
|
Have you run You can also try to run |
@russelarms Thnaks its worked. Able to update to 3.0.0 @Jamminroot @guperrot Updating to latest version solved the issue for me. You can close the issue now. Thanks a lot guys.. |
Glad it worked. |
There is another hint: DON'T add It had bothered me for a looooong time. Hope it's helpful to someone. |
I have an existing app that I want to integrate with Crashes SDK, but after following the instructions, the JS stack trace is still not showing.
This is what I got from the report instead
On the other hand, when I tried the SDK with a dummy app, it works perfectly, showing the correct stack trace of the JS crash.
The stack trace stops on RCTAssert.m if I forgot to upload the bundle along with the dSYM.
Assuming that the crash reporter needs to land on RCTAssert.m for it to work properly, I have additional information that might help. When using Crashlytics, the crash report lands correctly on RCTAssert.m.
I've also uninstalled Crashlytics to make sure the two crash reporters don't conflict.
The text was updated successfully, but these errors were encountered: