diff --git a/website/docs/Contribute.md b/website/docs/Contribute.md index 83a3a47eec0f..8f264c9bd731 100644 --- a/website/docs/Contribute.md +++ b/website/docs/Contribute.md @@ -54,6 +54,38 @@ print(autogen.__version__) There is currently no formal reviewer solicitation process. Current reviewers identify reviewers from active contributors. If you are willing to become a reviewer, you are welcome to let us know on discord. +## Guidance for Maintainers + +### General + +* Be a member of the community and treat everyone as a member. Be inclusive. +* Help each other and encourage mutual help. +* Actively post and respond. +* Keep open communication. + +### Pull Requests +* For new PR, decide whether to close without review. If not, find the right reviewers. The default reviewer is microsoft/autogen. Ask users who can benefit from the PR to review it. +* For old PR, check the blocker: reviewer or PR creator. Try to unblock. Get additional help when needed. +* When requesting changes, make sure you can check back in time because it blocks merging. +* Make sure all the checks are passed. +* For changes that require running OpenAI tests, make sure the OpenAI tests pass too. Running these tests requires approval. +* In general, suggest small PRs instead of a giant PR. +* For documentation change, request snapshot of the compiled website, or compile by yourself to verify the format. +* For new contributors who have not signed the contributing agreement, remind them to sign before reviewing. +* For multiple PRs which may have conflict, coordinate them to figure out the right order. +* Pay special attention to: + - Breaking changes. Don’t make breaking changes unless necessary. Don’t merge to main until enough headsup is provided and a new release is ready. + - Test coverage decrease. + - Changes that may cause performance degradation. Do regression test when test suites are available. + - Discourage **change to the core library** when there is an alternative. + +### Issues and Discussions +* For new issues, write a reply, apply a label if relevant. Ask on discord when necessary. For roadmap issues, add to the roadmap project and encourage community discussion. Mention relevant experts when necessary. +* For old issues, provide an update or close. Ask on discord when necessary. Encourage PR creation when relevant. +* Use “good first issue” for easy fix suitable for first-time contributors. +* Use “task list” for issues that require multiple PRs. +* For discussions, create an issue when relevant. Discuss on discord when appropriate. + ## Developing ### Setup @@ -82,6 +114,14 @@ We have provided the configuration in [devcontainer](https://github.com/microsof Run `pre-commit install` to install pre-commit into your git hooks. Before you commit, run `pre-commit run` to check if you meet the pre-commit requirements. If you use Windows (without WSL) and can't commit after installing pre-commit, you can run `pre-commit uninstall` to uninstall the hook. In WSL or Linux this is supposed to work. +### Write tests + +Tests are automatically run via GitHub actions. There are two workflows: +1. [build.yml](https://github.com/microsoft/autogen/blob/main/.github/workflows/build.yml) +1. [openai.yml](https://github.com/microsoft/autogen/blob/main/.github/workflows/openai.yml) + +The first workflow is required to pass for all PRs. The second workflow is required for changes that affect the openai tests. The second workflow requires approval to run. When writing tests that require openai, please use [`pytest.mark.skipif`](https://github.com/microsoft/autogen/blob/a456b512d5a933ce9707ce51c465ea35a9dd180c/test/test_with_openai.py#L13) to make them run in one python version only when openai is installed. If additional dependency for this test is required, install the dependency in the corresponding python version in [openai.yml](https://github.com/microsoft/autogen/blob/main/.github/workflows/openai.yml). + ### Coverage Any code you commit should not decrease coverage. To run all unit tests, install the [test] option: