feat(logical-size): Implement the LogicalSize property in Axe.Windows #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1020 +/- ##
==========================================
- Coverage 73.70% 72.13% -1.57%
==========================================
Files 398 424 +26
Lines 12046 13216 +1170
Branches 0 1420 +1420
==========================================
+ Hits 8878 9534 +656
- Misses 3168 3265 +97
- Partials 0 417 +417 ☔ View full report in Codecov by Sentry. |
DaveTryon
reviewed
May 2, 2024
codeofdusk
force-pushed
the
logical-size
branch
3 times, most recently
from
22b5ee0 to
c7ce931
Compare
Co-authored-by: Dave Tryon <45672944+DaveTryon@users.noreply.github.com>
brocktaylor7
approved these changes
May 16, 2024
|
I've added a unit test for the
|
This was referenced May 18, 2024
codeofdusk
added a commit
that referenced
this pull request
May 20, 2024
…1024) Axe.Windows follows semantic versioning, which states: > Given a version number MAJOR.MINOR.PATCH, increment the... MINOR version when you add functionality in a backward compatible manner I think 6d72b85 and d2a5c65 qualify as "new functionality" for these purposes, justifying a minor version bump. Also includes a small fix-up of #1020 to prevent execution of `a11yProperty.ToSize` on properties other than `LogicalSize`.
DaveTryon
reviewed
May 20, 2024
| private PropertyType() : base() | ||
| { | ||
| // Explicitly add pseudo-properties | ||
| Dic[Axe_LogicalSizePseudoPropertyId] = GetNameInProperFormat("Axe_LogicalSizePseudoPropertyId", Axe_LogicalSizePseudoPropertyId); |
There was a problem hiding this comment.
Should PropertyTypesTests.cs be updated to check that the pseudo-property exists and that the contents make sense? Abstracting out the screen DPI could get interesting...
codeofdusk
added a commit
that referenced
this pull request
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR adds a "pseudo-property",
LogicalSize, a normalized size based on an element'sBoundingRectangleto aid in touch size calculations.Motivation
Part of Feature 2152841 (internal access required to view).
Pull request checklist