Fix class case exception when create new application insights, fixes #…

…6585
microsoft · Apr 29, 2022 · aadafdf · aadafdf
1 parent 3eb3f70
commit aadafdf
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/...it-for-intellij/src/main/java/com/microsoft/intellij/ui/ApplicationInsightsNewDialog.java b/...it-for-intellij/src/main/java/com/microsoft/intellij/ui/ApplicationInsightsNewDialog.java
@@ -99,10 +99,10 @@ private ItemListener subscriptionListener() {
             Subscription newSub = (Subscription) comboSub.getSelectedItem();
             String prevResGrpVal = (String) comboGrp.getSelectedItem();
             this.comboReg.setSubscription(newSub);
-            if (currentSub.equals(newSub)) {
+            if (Objects.equals(currentSub, newSub)) {
                 populateResourceGroupValues(currentSub.getId(), prevResGrpVal);
             } else {
-                populateResourceGroupValues(currentSub.getId(), "");
+                populateResourceGroupValues(newSub.getId(), "");
             }
             currentSub = newSub;
         };
@@ -140,7 +140,7 @@ protected JComponent createTitlePane() {
     @Override
     protected void doOKAction() {
         final boolean grpNotSelected = Objects.isNull(comboGrp.getSelectedItem()) || ((String) comboGrp.getSelectedItem()).isEmpty();
-        final boolean regNotSelected = Objects.isNull(comboReg.getSelectedItem()) || ((String) comboReg.getSelectedItem()).isEmpty();
+        final boolean regNotSelected = Objects.isNull(comboReg.getSelectedItem());
         final boolean subNotSelected = comboSub.getSelectedItem() == null;
         if (txtName.getText().trim().isEmpty()
                 || subNotSelected
@@ -156,16 +156,17 @@ protected void doOKAction() {
             }
         } else {
             boolean isNewGroup = createNewBtn.isSelected();
+            Subscription subscription = comboSub.getValue();
             String resourceGroup = isNewGroup ? textGrp.getText() : (String) comboGrp.getSelectedItem();
             final AzureString title = AzureOperationBundle.title("ai.create_ai.ai|rg", txtName.getText(), resourceGroup);
             AzureTaskManager.getInstance().runInBackground(new AzureTask(null, title, false, () -> {
                 try {
                     ApplicationInsight resource = AzureSDKManager.createInsightsResource(
-                            currentSub,
+                            subscription,
                             resourceGroup,
                             isNewGroup,
                             txtName.getText(),
-                            (String) comboReg.getSelectedItem());
+                            comboReg.getValue().getName());
                     resourceToAdd = new ApplicationInsightsResource(resource, currentSub, true);
                     if (onCreate != null) {
                         onCreate.run();