From 8ce8b04b9f58b99f7b7f225d1dcdfe9b02def16f Mon Sep 17 00:00:00 2001 From: rishky-msft Date: Sun, 9 Apr 2023 12:58:04 +0530 Subject: [PATCH] Fixing voice over sev2s of new database dialog --- src/dialogs/newDatabaseDialog.ts | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/dialogs/newDatabaseDialog.ts b/src/dialogs/newDatabaseDialog.ts index cd91c40..abfcddc 100644 --- a/src/dialogs/newDatabaseDialog.ts +++ b/src/dialogs/newDatabaseDialog.ts @@ -57,9 +57,7 @@ export class NewDatabaseDialog { private onLoadingComplete(): void { this.databaseNameTextBox.enabled = true; - this.databaseCharsetDropDown.loading = false; this.databaseCharsetDropDown.enabled = true; - this.databaseCollationDropDown.loading = false; this.databaseCollationDropDown.enabled = true; } @@ -70,6 +68,7 @@ export class NewDatabaseDialog { private async loadAndUpdateCharsetValues(): Promise { try { + this.databaseCharsetDropDown.loading = true; var charsets: CharsetInfo[] = await ToolsServiceUtils.getCharsets(this.connectionOwnerUri, this.client); charsets.forEach(charset => { this.charsetsCache.push(charset.name); @@ -81,6 +80,9 @@ export class NewDatabaseDialog { // Log the error message and keep the values of charset as default. console.warn("New Database Tab : Unable to fetch charset values. Using default charset.") } + finally { + this.databaseCharsetDropDown.loading = false; + } } private initializeDialog(): void { @@ -155,8 +157,7 @@ export class NewDatabaseDialog { ariaLabel: DatabaseCharsetDropDownLabel, required: false, width: '310px', - enabled: false, - loading: true + enabled: false }).component(); this.databaseCharsetDropDown.onValueChanged(() => { @@ -197,8 +198,7 @@ export class NewDatabaseDialog { ariaLabel: DatabaseCollationDropDownLabel, required: false, width: '310px', - enabled: false, - loading: true + enabled: false }).component(); const databaseCollationLabel = view.modelBuilder.text().withProps({