Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"trustServerCertificate" showing unnecessarily on connection hover #23930

Closed
Charles-Gagnon opened this issue Jul 19, 2023 · 3 comments
Closed

"trustServerCertificate" showing unnecessarily on connection hover #23930

Charles-Gagnon opened this issue Jul 19, 2023 · 3 comments
Labels
Area - Connection Bug Triage: Needed
Milestone
July 2023 Release

Comments

@Charles-Gagnon
Copy link
Contributor

RC1

  1. Create new connection with "trustServerCertificate" as true
  2. Hover over connection

Title shows the trustServerCertificate value, even if it's the only connection for that server

image
@Charles-Gagnon Charles-Gagnon added this to the July 2023 Release milestone Jul 19, 2023
@Charles-Gagnon
Copy link
Contributor Author

@cheenamalhotra FYI

@cheenamalhotra
Copy link
Member

cheenamalhotra commented Jul 19, 2023 •
edited
Loading

This is by design to show non-default advanced options on hover (fix for #13274) captured in PR #23873 - we had this discussed with @aasimkhan30 as well from OE perspective

@Charles-Gagnon
Copy link
Contributor Author

Hrm, ok I guess that makes sense. Will be interested to see if people find this useful or annoying though - especially for a setting that we prompt them to enable when using a self-signed cert.

@aasimkhan30 aasimkhan30 mentioned this issue Jul 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area - Connection Bug Triage: Needed
Projects
None yet
Milestone
July 2023 Release
Development

No branches or pull requests
2 participants
@cheenamalhotra @Charles-Gagnon