Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/dotnet popup #10231

Merged
merged 6 commits into from
May 2, 2020
Merged

Feature/dotnet popup #10231

merged 6 commits into from
May 2, 2020

Conversation

udeeshagautam
Copy link
Contributor

@udeeshagautam udeeshagautam commented Apr 30, 2020

Added changes to pop up for Net core installation or path update if not present in default path. Pops up at only activate for now, will integrate with build when enabled.

This is how it looks

image

For reference : this is how C# extn. in Vscode looks

image

and the settings
image

@alanrenmsft
Copy link
Contributor

hmm, i think you should try the default location, if it is not there, then run dotnet command to make sure it is not in the PATH either before the prompt.

@udeeshagautam
Copy link
Contributor Author

hmm, i think you should try the default location, if it is not there, then run dotnet command to make sure it is not in the PATH either before the prompt.

Yeah I agree that but since we are having a setting for location, PATH doesn't make lot of sense and also I need the location for the short term build from tools service - once we move to VSCode tasks I can add check on PATH and not need the install location.

@github-actions
Copy link

Coverage Status

Coverage increased (+0.04%) to 32.704% when pulling d175566 on feature/dotnetPopup into af36d79 on master.

@udeeshagautam udeeshagautam merged commit e387382 into master May 2, 2020
@udeeshagautam udeeshagautam deleted the feature/dotnetPopup branch May 2, 2020 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants