Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for content visibility in prose preview page of Import Extension. #10278

Merged
merged 2 commits into from
May 7, 2020

Conversation

aasimkhan30
Copy link
Contributor

Changed the table property for better data visibility in the prose preview page

image

image

@aasimkhan30 aasimkhan30 requested a review from aaomidi May 6, 2020 03:36
@aasimkhan30 aasimkhan30 changed the title Fix for content visibility in prose preview for Import Extension. Fix for content visibility in prose preview page of Import Extension. May 6, 2020
@aasimkhan30 aasimkhan30 requested a review from kburtram May 6, 2020 21:15
Copy link
Contributor

@aaomidi aaomidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me as long as you've tested various edge cases of this (no data, very long values in cells, etc)

@aasimkhan30 aasimkhan30 merged commit 89a845d into master May 7, 2020
@aasimkhan30 aasimkhan30 deleted the aasim/import/gridDisplayFix branch May 7, 2020 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants