Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update system database references from SSDT #10891

Merged
merged 12 commits into from
Jun 13, 2020
Merged

Update system database references from SSDT #10891

merged 12 commits into from
Jun 13, 2020

Conversation

kisantia
Copy link
Contributor

This PR fixes #10863. This updates sqlproj files that had system database references added in SSDT to work in both SSDT and ADS.

udeeshagautam
udeeshagautam approved these changes Jun 12, 2020
View reviewed changes
Copy link
Contributor

@udeeshagautam udeeshagautam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good only request for that test and one failing check...

@coveralls
Copy link

coveralls commented Jun 12, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 34.573% when pulling 9398e3b on kisantia/ReferencesFromSSDT into 60c0ac6 on master.

@kisantia kisantia merged commit c9569d8 into master Jun 13, 2020
@kisantia kisantia deleted the kisantia/ReferencesFromSSDT branch June 13, 2020 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@udeeshagautam udeeshagautam udeeshagautam approved these changes

@Benjin Benjin Benjin approved these changes

@SakshiS-harma SakshiS-harma Awaiting requested review from SakshiS-harma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert system database references from SSDT
4 participants
@kisantia @coveralls @Benjin @udeeshagautam